From reviews-return-118-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org Thu Nov 29 11:12:39 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2AD0D18066C for ; Thu, 29 Nov 2018 11:12:39 +0100 (CET) Received: (qmail 63589 invoked by uid 500); 29 Nov 2018 10:12:38 -0000 Mailing-List: contact reviews-help@livy.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@livy.incubator.apache.org Delivered-To: mailing list reviews@livy.incubator.apache.org Received: (qmail 63578 invoked by uid 99); 29 Nov 2018 10:12:37 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Nov 2018 10:12:37 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 47A2CDFDA7; Thu, 29 Nov 2018 10:12:37 +0000 (UTC) From: mgaido91 To: reviews@livy.apache.org Reply-To: reviews@livy.apache.org References: In-Reply-To: Subject: [GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec Content-Type: text/plain Message-Id: <20181129101237.47A2CDFDA7@git1-us-west.apache.org> Date: Thu, 29 Nov 2018 10:12:37 +0000 (UTC) Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237423913 --- Diff: server/src/main/scala/org/apache/livy/LivyConf.scala --- @@ -98,10 +98,78 @@ object LivyConf { val LAUNCH_KERBEROS_REFRESH_INTERVAL = Entry("livy.server.launch.kerberos.refresh-interval", "1h") val KINIT_FAIL_THRESHOLD = Entry("livy.server.launch.kerberos.kinit-fail-threshold", 5) + // Thrift configurations val THRIFT_SERVER_ENABLED = Entry("livy.server.thrift.enabled", false) val THRIFT_INCR_COLLECT_ENABLED = Entry("livy.server.thrift.incrementalCollect", false) val THRIFT_SESSION_CREATION_TIMEOUT = Entry("livy.server.thrift.session.creationTimeout", "10m") val THRIFT_SERVER_JAR_LOCATION = Entry("livy.server.thrift.jarLocation", null) + // The following configs are the same present in Hive + val THRIFT_RESULTSET_DEFAULT_FETCH_SIZE = + Entry("livy.server.thrift.resultset.default.fetch.size", 1000) + val THRIFT_SPNEGO_PRINCIPAL = Entry("livy.server.thrift.authentication.spnego.principal", "") --- End diff -- yes, I thought about that too but I was not sure, so I kept this. Let me remove it and replace it with `AUTH_KERBEROS_PRINCIPAL` then. Thanks. ---