From reviews-return-54-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org  Wed Nov  7 01:15:44 2018
Return-Path: <reviews-return-54-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id B6DDE180658
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  7 Nov 2018 01:15:43 +0100 (CET)
Received: (qmail 70845 invoked by uid 500); 7 Nov 2018 00:15:42 -0000
Mailing-List: contact reviews-help@livy.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@livy.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@livy.incubator.apache.org>
List-Post: <mailto:reviews@livy.incubator.apache.org>
List-Id: <reviews.livy.incubator.apache.org>
Reply-To: reviews@livy.incubator.apache.org
Delivered-To: mailing list reviews@livy.incubator.apache.org
Received: (qmail 70827 invoked by uid 99); 7 Nov 2018 00:15:42 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Nov 2018 00:15:42 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id CAD4EE09EE; Wed,  7 Nov 2018 00:15:41 +0000 (UTC)
From: HyukjinKwon <git@git.apache.org>
To: reviews@livy.apache.org
Reply-To: reviews@livy.apache.org
References: <git-pr-121-incubator-livy@git.apache.org>
In-Reply-To: <git-pr-121-incubator-livy@git.apache.org>
Subject: [GitHub] incubator-livy pull request #121: [LIVY-518][BUILD] Support Spark 2.4
Content-Type: text/plain
Message-Id: <20181107001541.CAD4EE09EE@git1-us-west.apache.org>
Date: Wed,  7 Nov 2018 00:15:41 +0000 (UTC)

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/incubator-livy/pull/121#discussion_r231342303
  
    --- Diff: rsc/src/test/java/org/apache/livy/rsc/TestSparkClient.java ---
    @@ -271,7 +275,7 @@ public void call(LivyClient client) throws Exception {
     
       @Test
       public void testSparkSQLJob() throws Exception {
    -    runTest(true, new TestFunction() {
    +    runTest(true, false, new TestFunction() {
    --- End diff --
    
    @vanzin, thanks. I will investigate it within few days ... but would you mind if I do that as a followup job? I still suspect if it's specific to tests and shouldn't affect the functionailities within Livy.


---