livy-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <>
Subject [GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec
Date Thu, 29 Nov 2018 11:42:41 GMT
GitHub user mgaido91 reopened a pull request:

    [LIVY-502] Remove dependency on hive-exec

    ## What changes were proposed in this pull request?
    This PR removes the dependency on `hive-exec`. Only modules of Hive which are used after
this PR are `hive-service-rpc` and `hive-service`. This drastically reduces the amount of
JARs needed by the thriftserver module.
    The PR takes the Hive classes which we were using and adapts them when necessary (or simpify
when we don't need something) in order to work in the Livy thriftserver.
    Most of the classes are just migrated replacing all occurrences of `HiveConf`, `HiveSession`
and other Hive specific classes. Only one class has a quite different logic than Hive's and
it is `AuthFactory`, as we are using a different UGI handling from Hive (as we are not running
the TS in a standalone JVM).
    The functionalities we are taking from Hive are:
     - the thrift protocol endpoints (the classes in the `cli` package), ie. the classes handling
lower level details about the communication with the client;
     - the authentication layer (classes in the `auth` package, which are used in the ones
in `cli`), despite this PR leaves LDAP and PAM as out of scope as they are not trivial to
be ported and not needed for a working solution. We can add them later;
      - the classes in the `operation` package which are used to answer to metadata queries
by the JDBC driver.
    ## How was this patch tested?
    existing UTs + manual tests

You can merge this pull request into a Git repository by running:

    $ git pull LIVY-502

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
commit e7aa5b1c98e322fb60963bcca18965c5d874ce10
Author: Marco Gaido <mgaido@...>
Date:   2018-09-28T12:07:38Z

    [WIP][LIVY-502] Remove dependency on hive-exec

commit 545a5c3017e6daca022a61e8c51dbaefc98f8433
Author: Marco Gaido <mgaido@...>
Date:   2018-09-28T15:55:50Z

    fix Http thriftserver

commit 75aa6421bbf70eed4dfd311deebed703a8fe0c5a
Author: Marco Gaido <mgaido@...>
Date:   2018-10-02T10:18:20Z

    address comments

commit c5006a9aa35e717a172b67943269975ab830a3b9
Author: Marco Gaido <mgaido@...>
Date:   2018-11-29T10:13:04Z

    address comments

commit 0110fded4a988457eec7b48be991191026265da2
Author: Marco Gaido <mgaido@...>
Date:   2018-11-29T10:22:25Z

    Merge branch 'master' of into LIVY-502

commit f3040f682aa360aade2d4dfb2cc8bfc635c4a749
Author: Marco Gaido <mgaido@...>
Date:   2018-11-29T10:53:00Z

    fix merge



View raw message