livy-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] incubator-livy issue #117: [LIVY-502] Remove dependency on hive-exec
Date Thu, 29 Nov 2018 10:19:20 GMT
Github user mgaido91 commented on the issue:

    https://github.com/apache/incubator-livy/pull/117
  
    Thanks for the review @vanzin! I addressed your comments.
    
    > I still think there's stuff to clean up here
    
    Not sure what you mean here exactly, but I think that after this patch we may start working
with the Hive community in order to make some things easier to be re-used. Eg. we cannot reuse
all the auth classes because they depend on the `HiveConf` we may propose to the Hive community
to have them accepting in the constructor the parameters they need instead of the `HiveConf`,
so we can reuse them. This may help reducing significantly the code size here.


---

Mime
View raw message