livy-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From codecov-io <...@git.apache.org>
Subject [GitHub] incubator-livy issue #129: [LIVY-535] Fix non-atomic session creation
Date Thu, 22 Nov 2018 15:02:26 GMT
Github user codecov-io commented on the issue:

    https://github.com/apache/incubator-livy/pull/129
  
    # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/129?src=pr&el=h1) Report
    > Merging [#129](https://codecov.io/gh/apache/incubator-livy/pull/129?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-livy/commit/4cfb6bcb8fb9ac6b2d6c8b3d04b20f647b507e1f?src=pr&el=desc)
will **increase** coverage by `0.11%`.
    > The diff coverage is `87.5%`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-livy/pull/129/graphs/tree.svg?width=650&token=0MkVbiUFwE&height=150&src=pr)](https://codecov.io/gh/apache/incubator-livy/pull/129?src=pr&el=tree)
    
    ```diff
    @@             Coverage Diff              @@
    ##             master     #129      +/-   ##
    ============================================
    + Coverage     70.98%   71.09%   +0.11%     
    - Complexity      925      927       +2     
    ============================================
      Files           100      100              
      Lines          5511     5512       +1     
      Branches        829      830       +1     
    ============================================
    + Hits           3912     3919       +7     
    + Misses         1058     1053       -5     
    + Partials        541      540       -1
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/129?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
    |---|---|---|---|
    | [.../scala/org/apache/livy/server/SessionServlet.scala](https://codecov.io/gh/apache/incubator-livy/pull/129/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvU2Vzc2lvblNlcnZsZXQuc2NhbGE=)
| `67.07% <87.5%> (+0.4%)` | `16 <0> (ø)` | :arrow_down: |
    | [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/129/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==)
| `52.94% <0%> (-2.95%)` | `7% <0%> (ø)` | |
    | [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/129/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh)
| `30.76% <0%> (-2.57%)` | `7% <0%> (ø)` | |
    | [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/129/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=)
| `78.87% <0%> (-0.71%)` | `33% <0%> (ø)` | |
    | [.../scala/org/apache/livy/sessions/SessionState.scala](https://codecov.io/gh/apache/incubator-livy/pull/129/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvc2Vzc2lvbnMvU2Vzc2lvblN0YXRlLnNjYWxh)
| `61.11% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: |
    | [...in/java/org/apache/livy/rsc/driver/JobWrapper.java](https://codecov.io/gh/apache/incubator-livy/pull/129/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvSm9iV3JhcHBlci5qYXZh)
| `80% <0%> (ø)` | `8% <0%> (+1%)` | :arrow_up: |
    | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/129/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=)
| `79.23% <0%> (+1.27%)` | `42% <0%> (+1%)` | :arrow_up: |
    | [...c/src/main/java/org/apache/livy/rsc/RSCClient.java](https://codecov.io/gh/apache/incubator-livy/pull/129/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDbGllbnQuamF2YQ==)
| `83.85% <0%> (+3.72%)` | `26% <0%> (ø)` | :arrow_down: |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/129?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/129?src=pr&el=footer).
Last update [4cfb6bc...a01659a](https://codecov.io/gh/apache/incubator-livy/pull/129?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

Mime
View raw message