Return-Path: Delivered-To: apmail-labs-commits-archive@minotaur.apache.org Received: (qmail 30588 invoked from network); 13 Jul 2009 06:41:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 13 Jul 2009 06:41:51 -0000 Received: (qmail 4267 invoked by uid 500); 13 Jul 2009 06:42:01 -0000 Delivered-To: apmail-labs-commits-archive@labs.apache.org Received: (qmail 4145 invoked by uid 500); 13 Jul 2009 06:42:00 -0000 Mailing-List: contact commits-help@labs.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: labs@labs.apache.org Delivered-To: mailing list commits@labs.apache.org Received: (qmail 4136 invoked by uid 99); 13 Jul 2009 06:42:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jul 2009 06:42:00 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jul 2009 06:41:58 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 77AC12388878; Mon, 13 Jul 2009 06:41:38 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r793470 - in /labs/hupa/src/main/java/org/apache/hupa/client: mvp/IMAPMessageListView.java widgets/MyPagingScrollTable.java widgets/PagingScrollToolTipTable.java widgets/ToolTip.java Date: Mon, 13 Jul 2009 06:41:38 -0000 To: commits@labs.apache.org From: norman@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090713064138.77AC12388878@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: norman Date: Mon Jul 13 06:41:37 2009 New Revision: 793470 URL: http://svn.apache.org/viewvc?rev=793470&view=rev Log: Rename Widget to better reflect the features Fix bug in Tooltip generation Added: labs/hupa/src/main/java/org/apache/hupa/client/widgets/PagingScrollToolTipTable.java - copied, changed from r793468, labs/hupa/src/main/java/org/apache/hupa/client/widgets/MyPagingScrollTable.java Removed: labs/hupa/src/main/java/org/apache/hupa/client/widgets/MyPagingScrollTable.java Modified: labs/hupa/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java labs/hupa/src/main/java/org/apache/hupa/client/widgets/ToolTip.java Modified: labs/hupa/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java URL: http://svn.apache.org/viewvc/labs/hupa/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java?rev=793470&r1=793469&r2=793470&view=diff ============================================================================== --- labs/hupa/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java (original) +++ labs/hupa/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java Mon Jul 13 06:41:37 2009 @@ -31,7 +31,7 @@ import org.apache.hupa.client.mvp.IMAPMessageListPresenter.Display; import org.apache.hupa.client.rpc.EventBus; import org.apache.hupa.client.widgets.MyFixedWithGrid; -import org.apache.hupa.client.widgets.MyPagingScrollTable; +import org.apache.hupa.client.widgets.PagingScrollToolTipTable; import org.apache.hupa.client.widgets.ToolTipProvider; import org.apache.hupa.shared.data.IMAPFolder; import org.apache.hupa.shared.data.IMAPMessage; @@ -89,7 +89,7 @@ private IMAPFolder folder; private String searchValue; - private MyPagingScrollTable mailTable; + private PagingScrollToolTipTable mailTable; private EventBus bus; private MyFixedWithGrid dataTable = createDataTable(); @@ -101,7 +101,7 @@ VerticalPanel vPanel = new VerticalPanel(); - mailTable = new MyPagingScrollTable( + mailTable = new PagingScrollToolTipTable( new IMAPMessageTableModel(), dataTable, createHeaderTable(), createTableDefinitation(), new IMAPMessageToolTipProvider()); Copied: labs/hupa/src/main/java/org/apache/hupa/client/widgets/PagingScrollToolTipTable.java (from r793468, labs/hupa/src/main/java/org/apache/hupa/client/widgets/MyPagingScrollTable.java) URL: http://svn.apache.org/viewvc/labs/hupa/src/main/java/org/apache/hupa/client/widgets/PagingScrollToolTipTable.java?p2=labs/hupa/src/main/java/org/apache/hupa/client/widgets/PagingScrollToolTipTable.java&p1=labs/hupa/src/main/java/org/apache/hupa/client/widgets/MyPagingScrollTable.java&r1=793468&r2=793470&rev=793470&view=diff ============================================================================== --- labs/hupa/src/main/java/org/apache/hupa/client/widgets/MyPagingScrollTable.java (original) +++ labs/hupa/src/main/java/org/apache/hupa/client/widgets/PagingScrollToolTipTable.java Mon Jul 13 06:41:37 2009 @@ -28,16 +28,15 @@ import com.google.gwt.gen2.table.event.client.CellHighlightHandler; import com.google.gwt.gen2.table.event.client.CellUnhighlightEvent; import com.google.gwt.gen2.table.event.client.CellUnhighlightHandler; -import com.google.gwt.gen2.table.event.client.TableEvent.Cell; import com.google.gwt.user.client.Timer; import com.google.gwt.user.client.ui.Widget; -public class MyPagingScrollTable extends PagingScrollTable{ +public class PagingScrollToolTipTable extends PagingScrollTable{ private ToolTipProvider toolTipProvider = null; private Timer toolTipTimer; private ToolTip tTip; - public MyPagingScrollTable(TableModel tableModel, + public PagingScrollToolTipTable(TableModel tableModel, FixedWidthGrid dataTable, FixedWidthFlexTable headerTable, TableDefinition tableDefinition,ToolTipProvider tooltipProvider) { super(tableModel, dataTable, headerTable, tableDefinition); @@ -46,21 +45,22 @@ dataTable.addCellHighlightHandler(new CellHighlightHandler() { - public void onCellHighlight(final CellHighlightEvent event) { + public void onCellHighlight(CellHighlightEvent event) { + final int row = event.getValue().getRowIndex(); + final int cell = event.getValue().getCellIndex(); toolTipTimer= new Timer() { @Override public void run() { - Cell c = event.getValue(); - Widget w = toolTipProvider.getToolTipContent(getRowValue(c.getRowIndex()), c.getCellIndex(), c.getRowIndex()); + Widget w = toolTipProvider.getToolTipContent(getRowValue(row), cell,row); if (w != null) { - tTip = new ToolTip(w,3000); + tTip = new ToolTip(w,0); tTip.show(); } } }; - toolTipTimer.schedule(2000); + toolTipTimer.schedule(1000); } }); @@ -79,7 +79,7 @@ }); } - public MyPagingScrollTable(TableModel tableModel, + public PagingScrollToolTipTable(TableModel tableModel, FixedWidthGrid dataTable, FixedWidthFlexTable headerTable, TableDefinition tableDefinition) { this(tableModel, dataTable, headerTable, tableDefinition,null); Modified: labs/hupa/src/main/java/org/apache/hupa/client/widgets/ToolTip.java URL: http://svn.apache.org/viewvc/labs/hupa/src/main/java/org/apache/hupa/client/widgets/ToolTip.java?rev=793470&r1=793469&r2=793470&view=diff ============================================================================== --- labs/hupa/src/main/java/org/apache/hupa/client/widgets/ToolTip.java (original) +++ labs/hupa/src/main/java/org/apache/hupa/client/widgets/ToolTip.java Mon Jul 13 06:41:37 2009 @@ -23,7 +23,6 @@ import com.google.gwt.event.logical.shared.CloseEvent; import com.google.gwt.event.logical.shared.CloseHandler; import com.google.gwt.user.client.Timer; -import com.google.gwt.user.client.ui.Label; import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwt.user.client.ui.Widget; @@ -41,6 +40,7 @@ public ToolTip(Widget content, int showTimeMillis) { this.showTimeMillis = showTimeMillis; setWidget(content); + closeTimer = new Timer() { @Override @@ -54,7 +54,9 @@ } public void show() { - closeTimer.schedule(showTimeMillis); + if (showTimeMillis > 0) { + closeTimer.schedule(showTimeMillis); + } super.show(); } /** --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@labs.apache.org For additional commands, e-mail: commits-help@labs.apache.org