kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdcry...@apache.org
Subject kudu git commit: KUDU-2067. Enable cfile checksumming by default
Date Thu, 13 Jul 2017 18:30:15 GMT
Repository: kudu
Updated Branches:
  refs/heads/master b62608a8e -> f144d572d


KUDU-2067. Enable cfile checksumming by default

Cfile checksums were added in KUDU-463 but disabled
by default to help avoid any issues preventing
a user
from downgrading Kudu.

Note: This will a have minor impact on read and write throughput
due
to additional checksum creation, validation and data.

Change-Id: I615bf39cddcadbdac08b565f149106360e324269
Reviewed-on: http://gerrit.cloudera.org:8080/7409
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jdcryans@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/f144d572
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/f144d572
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/f144d572

Branch: refs/heads/master
Commit: f144d572d6434abdb0e65f86c80b48a23428b061
Parents: b62608a
Author: Grant Henke <granthenke@gmail.com>
Authored: Wed Jul 12 17:13:09 2017 -0500
Committer: Jean-Daniel Cryans <jdcryans@apache.org>
Committed: Thu Jul 13 18:29:46 2017 +0000

----------------------------------------------------------------------
 src/kudu/cfile/cfile_writer.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/f144d572/src/kudu/cfile/cfile_writer.cc
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/cfile_writer.cc b/src/kudu/cfile/cfile_writer.cc
index dbc47e9..5ca7f3d 100644
--- a/src/kudu/cfile/cfile_writer.cc
+++ b/src/kudu/cfile/cfile_writer.cc
@@ -63,7 +63,7 @@ DEFINE_string(cfile_do_on_finish, "flush",
               "Possible values are 'close', 'flush', or 'nothing'.");
 TAG_FLAG(cfile_do_on_finish, experimental);
 
-DEFINE_bool(cfile_write_checksums, false,
+DEFINE_bool(cfile_write_checksums, true,
             "Write CRC32 checksums for each block");
 TAG_FLAG(cfile_write_checksums, evolving);
 


Mime
View raw message