From dev-return-110536-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Jan 16 01:52:19 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D31BB18065E for ; Thu, 16 Jan 2020 02:52:18 +0100 (CET) Received: (qmail 42653 invoked by uid 500); 16 Jan 2020 01:52:17 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 42641 invoked by uid 99); 16 Jan 2020 01:52:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jan 2020 01:52:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 891A8C1289 for ; Thu, 16 Jan 2020 01:52:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.001 X-Spam-Level: X-Spam-Status: No, score=0.001 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 94dFRQuVR84O for ; Thu, 16 Jan 2020 01:52:13 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::233; helo=mail-oi1-x233.google.com; envelope-from=wangguoz@gmail.com; receiver= Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id EC2A27DDE8 for ; Thu, 16 Jan 2020 01:52:12 +0000 (UTC) Received: by mail-oi1-x233.google.com with SMTP id d62so17461292oia.11 for ; Wed, 15 Jan 2020 17:52:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ddE9mu4acASaXqZSYsmB1pDQtmTFMTlOyAuzEBqN9oA=; b=LRWC+VF7G+f6nCZh5kD+oBCaLWYGHyLgbvwXJLc9wd4+MsNy2+wHAIFHKPwtwPrdRT +y+vQqj/03/iC+J/USGSIOO+KWwc3PE32EkgCP7CPQtCrD+iHASkJymIGQsKCGjKwttX rrohMrorgyRSo50llfUppGSAshkS7QZSsu6cR90IMIIdd7NSxtWcQMZK1dRHFGGhy+QC b7B3Q9tW+0D/7cOQtAg9/2uleBP0/3AAITBuwYq75XqBvab/mFu2R4Z5JWeZdAZXYC+2 G+eLPpIbIF02GE61D4FUCyNq3duZn0xW2tk58hNOb+W0CXp2aKI2ORr/jpjkjV7QNxBp 00yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ddE9mu4acASaXqZSYsmB1pDQtmTFMTlOyAuzEBqN9oA=; b=O7CJ+hwICxCRn5Ii8M3etfuagV6Z/D/bZzmkp2rTORFNrNEsZAIbgaitgBUT9XERM2 cZOp4HS4j6CiNV8n+liHkSvulHXxthi5+jDsUFRc2NwOpi1pH9aA7hZQDi0jfrD4SUOD ZPwbTwOjqloQvUVkv5X8FqFkQBEqp5Z1MMdcDAYAJYGUAhD47n/rT/3y/z/mfjrzpgaa nxFg4QmcYuzV5b0qtShgjxIBMOB2SAhY9ZFrCe59i1sCZuJlnz/ftsybkoWS9kdf0iXl t2Z5qHsgTHtge4pBUAmbwHgnjMzVHkgv75FLu/foDLTEBY8c7pSEXxS1P1Hw5WU5TUFV aBHQ== X-Gm-Message-State: APjAAAVB5Ph6/NRO7xbIt3/Igg/33cU2c0VSQWy4+s0p/wH/LzPLCZ4U qBLlfVnjfNU3la2+BLRfLrWMNwFkHCUf3nFyi9jND+XfCJc= X-Google-Smtp-Source: APXvYqy7sYCVH+E4kYKCn4EMbfXSiDEFiISG+x/DbVUBf+NCy3EfO9Yb+OUov/zQ6zze25B8IPEAAwvi6NSAw9GSZFI= X-Received: by 2002:aca:8d5:: with SMTP id 204mr2262114oii.141.1579139525623; Wed, 15 Jan 2020 17:52:05 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Guozhang Wang Date: Wed, 15 Jan 2020 17:51:54 -0800 Message-ID: Subject: Re: [VOTE] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions To: dev Content-Type: multipart/alternative; boundary="00000000000079c572059c381234" --00000000000079c572059c381234 Content-Type: text/plain; charset="UTF-8" Hi Anna, Just a minor comment on the wiki page itself: ``` The new method, handleSerializationException, in ProductionExceptionHandler will be invoked when 1. ClassCastException is thrown while serializing record key / value. We will continue to throw this exception and not invoke the new method. ``` I think you meant to say that when ClassCastException is thrown, we would NOT trigger the handler method. But at the beginning it mentioned "will be invoked when.." which sounds a bit conflicting with itself. Could you update the wiki page? Otherwise, I'm +1 on this. Guozhang. On Wed, Jan 15, 2020 at 1:42 PM Matthias J. Sax wrote: > Thanks for pushing this KIP over the finish line! > > +1 (binding) > > > -Matthias > > On 1/15/20 12:57 PM, Bill Bejeck wrote: > > Thanks for the KIP. > > > > +1 (binding) > > > > -Bill > > > > On Wed, Jan 15, 2020 at 3:45 PM M. Manna wrote: > > > >> +1 (non-binding) > >> > >> Thanks for this KIP > >> > >> Regards, > >> > >> On Wed, 15 Jan 2020 at 20:35, Mitchell wrote: > >> > >>> +1(non-binding) > >>> > >>> Very useful > >>> -mitch > >>> > >>> On Wed, Jan 15, 2020, 3:29 PM Anna McDonald > >>> wrote: > >>> > >>>> Greetings, > >>>> I would like to propose a vote on KIP-399, extending the > >>>> ProductionExceptionHandler to cover serialization exceptions. This KIP > >>>> is aimed at improving the error-handling semantics in Kafka Streams > >>>> when Kafka Streams fails to serialize a message to the downstream > >>>> sink. > >>>> > >>>> KIP details located here: > >>>> > >>>> > >>> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-399%3A+Extend+ProductionExceptionHandler+to+cover+serialization+exceptions > >>>> > >>>> Discussion Thread: > >>>> > >>>> > >>> > >> > https://lists.apache.org/thread.html/rbbc887ca31d46f6e73ffc6e08df7e4bda69c89ff820986c30274e272%40%3Cdev.kafka.apache.org%3E > >>>> > >>>> Thanks, > >>>> anna > >>>> > >>> > >> > > > > -- -- Guozhang --00000000000079c572059c381234--