From dev-return-110537-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Jan 16 02:54:26 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EC92118065E for ; Thu, 16 Jan 2020 03:54:25 +0100 (CET) Received: (qmail 33659 invoked by uid 500); 16 Jan 2020 02:54:24 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 33646 invoked by uid 99); 16 Jan 2020 02:54:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jan 2020 02:54:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 740A61A3254 for ; Thu, 16 Jan 2020 02:54:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.015 X-Spam-Level: * X-Spam-Status: No, score=1.015 tagged_above=-999 required=6.31 tests=[KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Lm3MeTF02sFG for ; Thu, 16 Jan 2020 02:54:20 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=209.85.161.48; helo=mail-yw1-f48.google.com; envelope-from=admin@happypants.org; receiver= Received: from mail-yw1-f48.google.com (mail-yw1-f48.google.com [209.85.161.48]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 79E9BBC535 for ; Thu, 16 Jan 2020 02:54:20 +0000 (UTC) Received: by mail-yw1-f48.google.com with SMTP id 10so12091690ywv.5 for ; Wed, 15 Jan 2020 18:54:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=xOLfjP1LgovwH69hvA1rpabvbwHIqwsRW9PAcOqZ1MM=; b=c4PiEvIclUW9F1OJM5sLwbAQIsiWDOBnzlBsH3MJxpMSiGesCk36I8BwdSasw6gao4 CG7p9Fh2VodrzcFgiyaoPO2qBdipK7bSg5IyfKNKHOzGHO1pFWtE5BKTsUyDDgLr1hEv JRf3j22m/YdB2q/HjyUNU40pDCxLvGiw/1mZmdUM7ULeLzIeHWqF7E9aqlGR/DLOiWng yuIfUJ0xXEHiSsVmli6zMttgUURTiVoahV69nzPJGpVXVMx6LwIatWOmQJC9DNLtSiRz GmMsEp0FQziT1xsDb82XslLlgaq130vtKEX6BQg/nBLIIAG0At6Xehc/lPhTba4LdAB0 /8KQ== X-Gm-Message-State: APjAAAVj/xQjeLwiXitdtM04cYf3pW7Qwn3ioSixCekj0dJMVrzN9RON ENFgE68tQ7wEGDxJxz+yWWvWczTSd1tGupcXqTV9LhFx X-Google-Smtp-Source: APXvYqzbXud5nT0PVzNoVTJ95IvQvlzjZZu6OgbkIXwSQ+MNyY7NKfG9FHuy4ryE1A1IcuQFKzdVtsi3y5E+VqFZsVM= X-Received: by 2002:a81:7583:: with SMTP id q125mr23501361ywc.407.1579143253574; Wed, 15 Jan 2020 18:54:13 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Anna McDonald Date: Wed, 15 Jan 2020 21:54:03 -0500 Message-ID: Subject: Re: [VOTE] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions To: dev@kafka.apache.org Content-Type: text/plain; charset="UTF-8" Done. Thanks for pointing that out. anna On Wed, Jan 15, 2020 at 8:52 PM Guozhang Wang wrote: > > Hi Anna, > > Just a minor comment on the wiki page itself: > > ``` > > The new method, handleSerializationException, in ProductionExceptionHandler > will be invoked when > > 1. ClassCastException is thrown while serializing record key / value. We > will continue to throw this exception and not invoke the new method. > > ``` > > I think you meant to say that when ClassCastException is thrown, we would > NOT trigger the handler method. But at the beginning it mentioned "will be > invoked when.." which sounds a bit conflicting with itself. Could you > update the wiki page? > > Otherwise, I'm +1 on this. > > > Guozhang. > > > On Wed, Jan 15, 2020 at 1:42 PM Matthias J. Sax > wrote: > > > Thanks for pushing this KIP over the finish line! > > > > +1 (binding) > > > > > > -Matthias > > > > On 1/15/20 12:57 PM, Bill Bejeck wrote: > > > Thanks for the KIP. > > > > > > +1 (binding) > > > > > > -Bill > > > > > > On Wed, Jan 15, 2020 at 3:45 PM M. Manna wrote: > > > > > >> +1 (non-binding) > > >> > > >> Thanks for this KIP > > >> > > >> Regards, > > >> > > >> On Wed, 15 Jan 2020 at 20:35, Mitchell wrote: > > >> > > >>> +1(non-binding) > > >>> > > >>> Very useful > > >>> -mitch > > >>> > > >>> On Wed, Jan 15, 2020, 3:29 PM Anna McDonald > > >>> wrote: > > >>> > > >>>> Greetings, > > >>>> I would like to propose a vote on KIP-399, extending the > > >>>> ProductionExceptionHandler to cover serialization exceptions. This KIP > > >>>> is aimed at improving the error-handling semantics in Kafka Streams > > >>>> when Kafka Streams fails to serialize a message to the downstream > > >>>> sink. > > >>>> > > >>>> KIP details located here: > > >>>> > > >>>> > > >>> > > >> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-399%3A+Extend+ProductionExceptionHandler+to+cover+serialization+exceptions > > >>>> > > >>>> Discussion Thread: > > >>>> > > >>>> > > >>> > > >> > > https://lists.apache.org/thread.html/rbbc887ca31d46f6e73ffc6e08df7e4bda69c89ff820986c30274e272%40%3Cdev.kafka.apache.org%3E > > >>>> > > >>>> Thanks, > > >>>> anna > > >>>> > > >>> > > >> > > > > > > > > > -- > -- Guozhang