From dev-return-107141-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Wed Sep 4 07:25:16 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 26EE11804BB for ; Wed, 4 Sep 2019 09:25:16 +0200 (CEST) Received: (qmail 77108 invoked by uid 500); 4 Sep 2019 11:42:40 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 77096 invoked by uid 99); 4 Sep 2019 11:42:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Sep 2019 11:42:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 22DAD180D6C for ; Wed, 4 Sep 2019 07:25:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.801 X-Spam-Level: * X-Spam-Status: No, score=1.801 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=confluent.io Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Y9r4ygc_sxX8 for ; Wed, 4 Sep 2019 07:25:11 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=djacot@confluent.io; receiver= Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 3C8857DD5E for ; Wed, 4 Sep 2019 07:25:11 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id t16so20038084wra.6 for ; Wed, 04 Sep 2019 00:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=confluent.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=lWSD7sj0V2yYD8jabHerpp4C47UyPVjNDKRi8SNId5E=; b=YXr0jMlnMZJ/NFBtFRdRIP2GwSIZ8IbMmB38RW788/0ATiPzNg3iLedTyUddVRvTBy JNKIuhSGfVegmxu6/49MNgyHTdKuaXQAyqv20RE68L6cTVf+GvGj9vITY+mlVahyPXxW 3VjQhj7bf6TorSxF18zAxi96nYmEVzt0ZPOXz+cbYW0Fa4ZI83H0QGMLfBb0n9s/AYPO 1JlYxkubqF5UvLzXgA4XizHJ9LKJd5tjEPDAQR/izyU7YaIToSoEI/YNYX9K0iXtEd3X 1OUZhG31Z9JRTQ7fBUlB0HE4dJY04Gqso+cTlY9s3XUn+VaUogZwIwRf6NTcgm3D3az6 K2wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=lWSD7sj0V2yYD8jabHerpp4C47UyPVjNDKRi8SNId5E=; b=csKFkFbUdpEqt4Ke5TRJ3X8LWFWBWkqGpOz91I2ufubK8JAFcPOXiUU84YKO1kmoYa QE9OtfNpgLIvZCzacstkmljAN2PpJ4t/6tgwl8c+gElXRpmpIJCGT13UBYkmjqly6hBB NRelC88fqEua9TfCL+78jcGo5OsUt213fHHSlJZIlvLGhIgaW6eGKHrmAhv0mX/ZL1xp GCfd2SEydHRsG5gq7zAmNlBNjvSVqj6TabXW3dL/2u2Kcct6sUFqxf+ALuKIc3qjSlEz gdZ2EFBX6VzbuE8ve/5FUgHbQWSBekqCiRy1J3Q6ZRnka1sCbRhbqrZ6CfrLZ4JFfZo1 6ITA== X-Gm-Message-State: APjAAAURbkQgwbg/okmTj4qEPaISxFWpzz9JRSvkmgE9fS1ZM8tE1IYh YoT4ZxrdWv7o7QxJ31Lld/0zFc3zhHOs/6jM6RguLecft/I= X-Google-Smtp-Source: APXvYqz45jvdTy/HTDvCxtLD0YaJpa3EX2AJVNff03TlkA2AyB6G0AotKLbQZH0WnqBHze8O3f2kMTmO2OTPae2XKfU= X-Received: by 2002:a5d:6185:: with SMTP id j5mr26308952wru.99.1567581904836; Wed, 04 Sep 2019 00:25:04 -0700 (PDT) MIME-Version: 1.0 References: <6aa84b11-d090-4eb0-97bb-9333a2857cbb@www.fastmail.com> In-Reply-To: From: David Jacot Date: Wed, 4 Sep 2019 09:24:54 +0200 Message-ID: Subject: Re: [VOTE] KIP-496: Administrative API to delete consumer offsets To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="00000000000098380e0591b51a59" --00000000000098380e0591b51a59 Content-Type: text/plain; charset="UTF-8" Hi all, While implementing the KIP, I have realized that a new error code and exception is required to notify the caller that offsets of a topic can not be deleted because the group is actively subscribed to the topic. I would like to know if there are any concerns with these changes before updating the KIP. *Proposed API:* GROUP_SUBSCRIBED_TO_TOPIC(86, "The consumer group is actively subscribed to the topic", GroupSubscribedToTopicException::new); public class GroupSubscribedToTopicException extends ApiException { public GroupSubscribedToTopicException(String message) { super(message); } } Best, David On Fri, Aug 16, 2019 at 10:58 AM Mickael Maison wrote: > +1 (non binding) > Thanks! > > On Thu, Aug 15, 2019 at 11:53 PM Colin McCabe wrote: > > > > On Thu, Aug 15, 2019, at 11:47, Jason Gustafson wrote: > > > Hey Colin, I think deleting all offsets is equivalent to deleting the > > > group, which can be done with the `deleteConsumerGroups` api. I debated > > > whether there should be a way to delete partitions for all unsubscribed > > > topics, but I decided to start with a simple API. > > > > That's a fair point-- deleting the group covers the main use-case for > deleting all offsets. So we might as well keep it simple for now. > > > > cheers, > > Colin > > > > > > > > I'm going to close this vote. The final result is +3 with myself, > Guozhang, > > > and Colin voting. > > > > > > -Jason > > > > > > On Tue, Aug 13, 2019 at 9:21 AM Colin McCabe > wrote: > > > > > > > Hi Jason, > > > > > > > > Thanks for the KIP. > > > > > > > > Is there ever a desire to delete all the offsets for a given group? > > > > Should the protocol and tools support this? > > > > > > > > +1 (binding) > > > > > > > > best, > > > > Colin > > > > > > > > > > > > On Mon, Aug 12, 2019, at 10:57, Guozhang Wang wrote: > > > > > +1 (binding). > > > > > > > > > > Thanks Jason! > > > > > > > > > > On Wed, Aug 7, 2019 at 11:18 AM Jason Gustafson < > jason@confluent.io> > > > > wrote: > > > > > > > > > > > Hi All, > > > > > > > > > > > > I'd like to start a vote on KIP-496: > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-496%3A+Administrative+API+to+delete+consumer+offsets > > > > > > . > > > > > > +1 > > > > > > from me of course. > > > > > > > > > > > > -Jason > > > > > > > > > > > > > > > > > > > > > -- > > > > > -- Guozhang > > > > > > > > > > > > > --00000000000098380e0591b51a59--