From dev-return-107183-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Wed Sep 4 20:54:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BF2FD180674 for ; Wed, 4 Sep 2019 22:54:29 +0200 (CEST) Received: (qmail 41498 invoked by uid 500); 5 Sep 2019 02:57:24 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 41442 invoked by uid 99); 5 Sep 2019 02:57:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Sep 2019 02:57:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A5214182AC0 for ; Wed, 4 Sep 2019 20:54:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.801 X-Spam-Level: * X-Spam-Status: No, score=1.801 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id qTrO2QQi1r8I for ; Wed, 4 Sep 2019 20:54:25 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::836; helo=mail-qt1-x836.google.com; envelope-from=maulin.vasavada@gmail.com; receiver= Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 9E6A87DD32 for ; Wed, 4 Sep 2019 20:54:24 +0000 (UTC) Received: by mail-qt1-x836.google.com with SMTP id r15so65926qtn.12 for ; Wed, 04 Sep 2019 13:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=XPSIJ3vHe1Sg7I1+8wb1G/5IR1Kvd4ZZQ8kV5ERH944=; b=kKk9/OQAXIJtOI0WSV6hhmJGze77/uCrFye+rM9yZ2GbnwSb8MsZrHaGMc+DSN8Omv X0q0UGEQUmgQHLeUXbM7YWzTbctsj8APAVrXPz3tn3Zv54QQ5Uj2cIXpLurgHmfw/oS4 0lFxg2/WjD4l6tDL7ualRqTMqRjUkJd06w5Qmjnz4ULfwmKdUQi8UhL2UD1k1nnvY+Yp E/phapd0tfFijF0ySF3/FhQaZvcFm0K995VUPgiTa6Y4fGiO+9Zv9x2fjyCOtVpuC4kl jYUq/4eyMEHr6xuvt26IpQvWGmmAJ2vas2/9b5VRNbcvSc1uD3uufg11L1Rns9KAmI0z 5+qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=XPSIJ3vHe1Sg7I1+8wb1G/5IR1Kvd4ZZQ8kV5ERH944=; b=hdr5xo7KtS9o5MPnJMZra16zfHmLp9s77IBwMqXJYvgpHVJyDGoSvKlC4eUt2J9fXD 5CtOqLZamYfrf/LPxfF0x+9vV8irTlxjdRQ3u/WnhmnWVfM69XvRi3+I1GdXmqShEIll 4PeFQCLyXstlRoiMVD6GMCbKkLxa+0NkoKnaJCXXh80jDIFC7k1z8/5Xvw2htt3/QK3a CIEC5AMcicbXpdSQHyHeCue8g3Dd19Gld4soAlL9wD2ybWNCYMlrS3ZqC4p3VxYiqC+q 6J5gP0n5i8lQsntQScH55DcGHjapPnUh33Mc4QG06XE1GzC9NiHzpuztMS7XKQZaEsk1 e1YQ== X-Gm-Message-State: APjAAAUEROdvaSMfiyD5rnEe/OymLYRhH4JWd2+Vd847BdDgeC48VSSH 8A2PvSpMFPdLQyEXwDxwbGQFbfZTW2Kxrs/xBcI7Kg0Y X-Google-Smtp-Source: APXvYqwiurAyZtp0AQTGgshKD52YHa4at/zWzhLIjdSfqwtzX28OPHd2oAhsoS18GUCzirKPgfZRlZf8aQHrwtR75KI= X-Received: by 2002:ac8:414b:: with SMTP id e11mr53442qtm.174.1567630457989; Wed, 04 Sep 2019 13:54:17 -0700 (PDT) MIME-Version: 1.0 References: <348f3daed0d8414b8facc955a2f1dcde@IBIMAILD.ibi.com> <462a9f06-5cd7-4794-91bd-e502b0177b74@www.fastmail.com> <852b0c2c-70d6-4b95-a1e3-608068dd1e72@www.fastmail.com> <544901e9224348afbdc19a7c30b64a48@IBIMAILD.ibi.com> In-Reply-To: <544901e9224348afbdc19a7c30b64a48@IBIMAILD.ibi.com> From: Maulin Vasavada Date: Wed, 4 Sep 2019 13:54:06 -0700 Message-ID: Subject: Re: [DISCUSS] KIP-486 Support for pluggable KeyStore and TrustStore To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="000000000000966c8d0591c06898" --000000000000966c8d0591c06898 Content-Type: text/plain; charset="UTF-8" Do you guys think it would be easier if you can provide comments on GitHub and we can continue there and summarize the conclusion here? We should not lose addressing any comments. On Wed, Sep 4, 2019 at 12:34 PM Pellerin, Clement wrote: > The proposed interface does not look like the Builder pattern I am used to. > Should SslEngineBuilder be called SslEngineFactory instead? > > On Mon, Sep 2, 2019, at 03:33, Rajini Sivaram wrote: > > I would expect SslEngineBuilder interface to look something like this, > > perhaps with some tweaking: > > > > public interface SslEngineBuilder extends Configurable, Closeable { > > > > Set reconfigurableConfigs(); > > > > boolean shouldBeRebuilt(Map nextConfigs); > > > > SSLEngine createSslEngine(Mode mode, String peerHost, int > > peerPort, String endpointIdentification); > > > > } > --000000000000966c8d0591c06898--