From dev-return-105612-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Jul 11 16:32:19 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D52A11804BB for ; Thu, 11 Jul 2019 18:32:18 +0200 (CEST) Received: (qmail 90637 invoked by uid 500); 11 Jul 2019 16:32:16 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 90615 invoked by uid 99); 11 Jul 2019 16:32:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jul 2019 16:32:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 514D21A409D for ; Thu, 11 Jul 2019 16:32:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.095 X-Spam-Level: * X-Spam-Status: No, score=1.095 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_NO_HELO_DNS=1.294, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=confluent.io Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id aThBNiqcExWv for ; Thu, 11 Jul 2019 16:32:13 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.128.50; helo=mail-wm1-f50.google.com; envelope-from=john@confluent.io; receiver= Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id B55CFBC7AD for ; Thu, 11 Jul 2019 16:32:12 +0000 (UTC) Received: by mail-wm1-f50.google.com with SMTP id h19so7359369wme.0 for ; Thu, 11 Jul 2019 09:32:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=confluent.io; s=google; h=mime-version:from:date:message-id:subject:to; bh=k+hvb84rEKicp4SoIrRd7rZ4F95Dv/ejCIFG/03/vvs=; b=AmyV+IsAOAu5Wm7zm1w8c/HuLzuyAKq7J/hPL90+vdTa3Gg2YqFGs4OLMRAPjrU/9P GLhhdDpK4VAlR1vf6LpO0IjdwJnni9hAc4gFpTu5gFnFrzH2fTXVhUMRzGwGsAPYRwJB /WtS7pXolExe6WL3qvlCCoBxYlgEJccsYozCw8v6P2PcknyusmdEoPopOnHEe6CMRIX4 bOLdxH/UZTYpJvDU4LCT6LT5IRH8Lpz6GBmOAv7JYl2Rhk+51IAyi6ms7E/YpBhL5BcB TXhYXtXqPKLqFmgndaTzcoou3qGOTauGx/GLq9nsfkfPzPyGtP8ta00q1DRCOKzYD3LI fFGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=k+hvb84rEKicp4SoIrRd7rZ4F95Dv/ejCIFG/03/vvs=; b=SUu7tvB8T/oca32CBTSJCBBesu2XSLCwshFl2ifi/B1N3WjNp3vBiNPq8FBIezz9+E 3uhFyKPKCRZF56gVtqoKkzJnX+z6xCOhSMTImKM0JQGXDZD2poS3J6U1aXOM40VHC3iI FMdQFY+NhbYd7q/cuBILF6nilKz9fOXcfZsZ2BLOPvgmvGqE2kPxXJwpwFuTka4olTup 1BJbOoCpLjEjPMICJcV61eTIwX5MxBp04p6OsWVqx7lKew8Vys6/RwhuTmVHzFtWfu3d bBUY28Y10mlDSgK4CS9vvpslAIkoFcTf5hAX7I+qWqwj/La9FlU0KByfQMwP3oJZoEmv D3Qw== X-Gm-Message-State: APjAAAUZ/KT92ITfsQRncJO0WFJx6Hkc1Z+XLa2j1v70O6ZcFtRqulLO dmSWvYneZmSUlG5iARJ1ZNFEzR3F9UnFYWScmzY7mzigKRI= X-Google-Smtp-Source: APXvYqxMA+6wSvR2VkFwWLR6belUeVd4QmeJlIHmGWBJFZfdaYsgox2kPfaM63izSdx3GjsL2gU7r+FmDiNdVCfhRlo= X-Received: by 2002:a05:600c:23d2:: with SMTP id p18mr4881284wmb.108.1562862725912; Thu, 11 Jul 2019 09:32:05 -0700 (PDT) MIME-Version: 1.0 From: John Roesler Date: Thu, 11 Jul 2019 11:31:54 -0500 Message-ID: Subject: [DISCUSS] KIP-488: Clean up Sum,Count,Total Metrics To: dev@kafka.apache.org Content-Type: text/plain; charset="UTF-8" Hi Kafka devs, I'd like to propose KIP-488 as a minor cleanup of some of our metric implementations. KIP-488: https://cwiki.apache.org/confluence/x/kkAyBw Over time, iterative updates to these metrics has resulted in a pretty confusing little collection of classes, and I've personally been involved in three separate moderately time-consuming iterations of me or someone else trying to work out which metrics are available, and which ones are desired for a given use case. One of these was actually a long-running bug in Kafka Streams' metrics, so not only has this confusion been a time sink, but it has also led to bugs. I'm hoping this change won't be too controversial. Thanks, -John