kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mayuresh Gharat <gharatmayures...@gmail.com>
Subject Re: [DISCUSS] : KIP-410: Add metric for request handler thread pool utilization by request type
Date Wed, 02 Jan 2019 16:36:29 GMT
Hi Stanislav,

Thanks a lot for the feedback and sorry for the late reply.
I agree that we can have the name "RequestHandlerPoolUsagePercent" instead
of "RequestHandlerPoolUsageRate".
The main reason, why I named it rate was because of the discussion we had
on the corresponding jira.
But now, that I think of it, it is actually a fraction of the usage, so the
"percent" sounds better than the "rate".

Thanks,

Mayuresh

On Wed, Dec 26, 2018 at 1:56 AM Stanislav Kozlovski <stanislav@confluent.io>
wrote:

> Hey there Mayuresh,
>
> Thanks for the KIP! This will prove to be very useful.
>
> I am wondering whether we should opt for the name of `
> RequestHandlerPoolUsagePercent`. We seem to use the "Percent" suffix to
> denote fractions of times in other places - e.g
> `NetworkProcessorAvgIdlePercent`
>
> <td>The average fraction of time the network processors are idle</td>
>
> <td>kafka.network:type=SocketServer,name=NetworkProcessorAvgIdlePercent</td>
> <td>between 0 and 1, ideally &gt 0.3</td>
>
>
> Whereas we use the "Rate" suffix to denote the number of events per second
> - e.g the clients' "connection-close-rate"
>
> <tr>
>   <td>connection-close-rate</td>
>   <td>Connections closed per second in the window.</td>
>
> <td>kafka.[producer|consumer|connect]:type=[producer|consumer|connect]-metrics,client-id=([-.\w]+)</td>
> </tr>
>
>
> A separate nit - you may want to update the discussion thread link in the
> KIP as it is pointing to the default one.
>
> Thanks,
> Stanislav
>
> On Thu, Dec 20, 2018 at 9:58 PM Mayuresh Gharat <
> gharatmayuresh15@gmail.com>
> wrote:
>
> > I would like to get feedback on the proposal to add a metric for request
> > handler thread pool utilization by request type. Please find the KIP
> here :
> > KIP-410: Add metric for request handler thread pool utilization by
> request
> > type
> > <
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-410%3A+Add+metric+for+request+handler+thread+pool+utilization+by+request+type
> > >
> >
> >
> > Thanks,
> >
> > Mayuresh
> >
>
>
> --
> Best,
> Stanislav
>


-- 
-Regards,
Mayuresh R. Gharat
(862) 250-7125

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message