From dev-return-96615-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Wed Aug 1 14:08:33 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E212A180634 for ; Wed, 1 Aug 2018 14:08:32 +0200 (CEST) Received: (qmail 47303 invoked by uid 500); 1 Aug 2018 12:08:31 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 47289 invoked by uid 99); 1 Aug 2018 12:08:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2018 12:08:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A684E1A03A2 for ; Wed, 1 Aug 2018 12:08:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.888 X-Spam-Level: * X-Spam-Status: No, score=1.888 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id HiagQpYwSoLh for ; Wed, 1 Aug 2018 12:08:29 +0000 (UTC) Received: from mail-qk0-f176.google.com (mail-qk0-f176.google.com [209.85.220.176]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 433955F1BD for ; Wed, 1 Aug 2018 12:08:29 +0000 (UTC) Received: by mail-qk0-f176.google.com with SMTP id 27-v6so12428926qkv.0 for ; Wed, 01 Aug 2018 05:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=gz31SdZU/72y5iSbgJTKZO6tv1/A4uH7f0VQRR7x+J8=; b=sEoMUjj5FAF4VDyYfkKobP3HNKkxB+M0n3RbUF68KbYjezSAb+wh9Miy6m0dVPUoe9 eF0fSoP5uQ/kDWhtnMJpjpFR/g6de+ROUu/REYrTspXqQh20lR8TAZaIamRpG2jlY34i yvRE0bETeL3nNARnUHIw3QqVOGbgF2EzbfPebbBocR3fDykuHGIhNSh1TFPWrnR/0+hI 3LnIOgizKz7gHSn5lnehkeb1iUfTyeos18FPm5k5prA8VHQZm4BwxCPye4tivJG4W68F 3Ny36kk9GQiGjQMLspMRRM6qkWcCkhl4x6q9Ucd+ocRYN6Yd3toSVTDFD+9EUbOnxvGv JRCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=gz31SdZU/72y5iSbgJTKZO6tv1/A4uH7f0VQRR7x+J8=; b=MwId1VF0aiCgl25PU1uZagVkPhtu8yp7QAfhVy6Icc+5lD+n3SSxM+G1N0d4D2qwZO Zuqh6+sgmD4lCHztvEMMSJ5N+bUMJk2oA0gsvnIkxnyf2f62ZbHj+xVYJ7sd5UXHMO0P 3k9KekROmRIhw7gTNNyiYvaWjlYF9I36EBkse754SDG12Y85xIjY+RwDko67FHKzsa7J yhe3q5rOfLOIwjpTb9JC4ki147EJwZqEMpM5YfX4Sryk+eqJXW9Fk6Y/QlPv27odQp+8 T99R+Tsbnj1Mj2aoaNq0tULNDIsHMdYCCbwrF6y+M6ajgW3nRnLx6G/ymtEkMI30FgJp Kh0g== X-Gm-Message-State: AOUpUlEY/1Y57p3xEZ174HURfPENGr8TJgV+hT61Rnp9fl8z/IQSTet0 1x+BUq1AeGEst15zfxuLnBwpCNB8tU9M/KlMVy4Rmw== X-Google-Smtp-Source: AAOMgpfI6lfrGb9AXMzv3pmG9ljF2xN7ot99MpLSzvisn5FWqMSmaOyazcMeua9tVEZ23tKJTBCXdTaTAONScaI5LLY= X-Received: by 2002:a37:50c3:: with SMTP id e186-v6mr23120315qkb.91.1533125303740; Wed, 01 Aug 2018 05:08:23 -0700 (PDT) MIME-Version: 1.0 References: <76eaf3ed-7a3d-d7a0-d3f2-70b594e694bb@confluent.io> In-Reply-To: Reply-To: damian.guy@gmail.com From: Damian Guy Date: Wed, 1 Aug 2018 13:08:12 +0100 Message-ID: Subject: Re: [Vote] KIP-321: Update TopologyDescription to better represent Source and Sink Nodes To: Ewen Cheslack-Postava Cc: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="000000000000202dff05725e8dcf" --000000000000202dff05725e8dcf Content-Type: text/plain; charset="UTF-8" Ewen - no as I don't believe they are never null. Whereas the topicNameExtractor method returns null if it is the default extractor or the extractor. So i think this would be better to be optional as it is optionally returning a TopicNameExtractor On Tue, 31 Jul 2018 at 23:01 Ewen Cheslack-Postava wrote: > Generally +1 (binding) > > It would be helpful to just provide the full, updated interfaces in the > KIP and mark things as new with comments if needed. I had to go back and > read the discussion thread to make sure I was understanding the intent > correctly. > > Damian -- if we make that Optional, shouldn't the methods on Source also > be Optional types? > > -Ewen > > On Mon, Jul 30, 2018 at 11:13 PM Damian Guy wrote: > >> Hi Nishanth, >> >> I have one nit on the KIP. I think the topicNameExtractor method should >> return Optional rather than null. >> Sorry I'm late here. >> >> Thanks, >> Damian >> >> On Tue, 31 Jul 2018 at 01:14 Nishanth Pradeep >> wrote: >> >> > We need one more binding vote. >> > >> > Binding Votes: >> > >> > - Matthias J. Sax >> > - Guozhang Wong >> > >> > Community Votes: >> > >> > - Bill Bejeck >> > - Ted Yu >> > >> > Best, >> > Nishanth Pradeep >> > >> > On Fri, Jul 27, 2018 at 10:02 AM Bill Bejeck wrote: >> > >> > > Thanks for the KIP! >> > > >> > > +1 >> > > >> > > -Bill >> > > >> > > On Thu, Jul 26, 2018 at 2:39 AM Guozhang Wang >> > wrote: >> > > >> > > > +1 >> > > > >> > > > On Wed, Jul 25, 2018 at 11:13 PM, Matthias J. Sax < >> > matthias@confluent.io >> > > > >> > > > wrote: >> > > > >> > > > > +1 (binding) >> > > > > >> > > > > -Matthias >> > > > > >> > > > > On 7/25/18 7:47 PM, Ted Yu wrote: >> > > > > > +1 >> > > > > > >> > > > > > On Wed, Jul 25, 2018 at 7:24 PM Nishanth Pradeep < >> > > > nishanthp21@gmail.com> >> > > > > > wrote: >> > > > > > >> > > > > >> Hello, >> > > > > >> >> > > > > >> I'm calling a vote for KIP-321: >> > > > > >> >> > > > > >> >> > > > > >> >> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-321%3A+Update+ >> > > > > TopologyDescription+to+better+represent+Source+and+Sink+Nodes >> > > > > >> >> > > > > >> Best, >> > > > > >> Nishanth Pradeep >> > > > > >> >> > > > > > >> > > > > >> > > > > >> > > > >> > > > >> > > > -- >> > > > -- Guozhang >> > > > >> > > >> > >> > --000000000000202dff05725e8dcf--