From dev-return-96687-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Aug 2 18:28:47 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7EB3B180629 for ; Thu, 2 Aug 2018 18:28:46 +0200 (CEST) Received: (qmail 1531 invoked by uid 500); 2 Aug 2018 16:28:45 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 1518 invoked by uid 99); 2 Aug 2018 16:28:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Aug 2018 16:28:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3736DC1C09 for ; Thu, 2 Aug 2018 16:28:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.988 X-Spam-Level: * X-Spam-Status: No, score=1.988 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=berkeley-edu.20150623.gappssmtp.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 31epO5nE6lIY for ; Thu, 2 Aug 2018 16:28:43 +0000 (UTC) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8BBE65F3F0 for ; Thu, 2 Aug 2018 16:28:42 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id n96-v6so2006003lfi.1 for ; Thu, 02 Aug 2018 09:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=berkeley-edu.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=dgK4N7KOb/NaXK4yGqzU1A/Wlw43zye8Qp5XXvhXPL0=; b=iyBYyRnSTCdJD3hI8AlAP9b3jA90FHridtHQjZRK8hoZIvZ5oNxSMqItfNQIsNGoCo +XWRH9I5NcqUR48g+WmgfxmY/FOu69GIoHy+YglNoEaZIJ64bOqRMxFmWAuvXOLLoK4u XdLxf1H/fbPANRfmKTJACIb0SvgHT+NhscTSdUO9GsCDHvaaI7cWeNlmG3AnFEEsHIig xVR3UGxhoPfb+HDUMbLlKK2b8g0XraJkmHhHAU5SlGVtFCScJRgFabXu+0+5hJyKjMiS LZ/rpmTtP6QM+EBm7vYyJyzXnyvUMJwPwyxW99+j+y/qzpXJQhK1ipoqq1KNdywMH5qn TJpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=dgK4N7KOb/NaXK4yGqzU1A/Wlw43zye8Qp5XXvhXPL0=; b=TBBlMGM4wqgolU3+n6cUEFbQ8yOrdul7kiNSpSPi96xST1jqcryIUw1/80V7xt//5Q /nzzrZQYPHR1lSsb/iKiSmP9bLbGkn19gEA2ZDkdkkVxdw1F0JfkXw9dwYqmoSKky8tX Uc1UkbsZGTEkPcEDBdXadFybxyamVmFqIbA+mzGKt/S1GyIZlDmYNIPOed7nD2JD+97x ZHHZW760BaN7ozNBRVY6nmlBk74UqBHWIIvaW59xJs0TZiMlY47XvwEyZOxBpMfmlr6x 3KLLfJBWG7L7tG+Z6o3B8VMn9dRCIwexH5RxlPcvzLShAthqnx3+FUL9Tt0RNWQte656 +Drw== X-Gm-Message-State: AOUpUlFSaQdbqi0IVMn4xsF00FfHi16L406ZS49LL3oF7QIfpvw/l9ox /VkGeQcZ/S2TPyAycafeiHKj+yfvbqN6jp7+zipJ4PMV9IQ= X-Google-Smtp-Source: AAOMgpf6yQHV9YsII+rnKyLnSvt0FoJ8HZ1a8FjhVRuIIoGNfRbNvfJPwv4lWdEnR7Cq03bTSCyHAW03FfBskcCQkuE= X-Received: by 2002:a19:ef13:: with SMTP id n19-v6mr2435916lfh.48.1533227320895; Thu, 02 Aug 2018 09:28:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kevin Lu Date: Thu, 2 Aug 2018 09:28:29 -0700 Message-ID: Subject: Re: [DISCUSS] KIP-351: Add --critical-partitions option to describe topics command To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="000000000000d2854a0572764d20" --000000000000d2854a0572764d20 Content-Type: text/plain; charset="UTF-8" Hi Mickael, Thanks for the suggestion! Correct me if I am mistaken, but if a producer attempts to send to a partition that is under min ISR (and ack=all or -1) then the send will fail with a NotEnoughReplicas or NotEnoughReplicasAfterAppend exception? At this point, client-side has already suffered failure but the server-side is still fine for now? If the above is true, then this would be a FATAL case for producers. Would it be valuable to include the CRITICAL case where a topic partition has exactly min ISR so that Kafka operators can take action so it does not become FATAL? This could be in the same option or a new one. Thanks! Regards, Kevin On Thu, Aug 2, 2018 at 2:27 AM Mickael Maison wrote: > What about also adding a --under-minisr-partitions option? > > That would match the > "kafka.server:type=ReplicaManager,name=UnderMinIsrPartitionCount" > broker metric and it's usually pretty relevant when investigating > issues > > On Thu, Aug 2, 2018 at 8:54 AM, Kevin Lu wrote: > > Hi friends! > > > > This thread is to discuss KIP-351 > > < > https://cwiki.apache.org/confluence/display/KAFKA/KIP-351%3A+Add+--critical-partitions+option+to+describe+topics+command > > > > ! > > > > I am proposing to add a --critical-partitions option to the describe > topics > > command that will only list out topic partitions that have 1 ISR left > (RF > > > 1) as they would be in a critical state and need immediate > repartitioning. > > > > I wonder if the name "critical" is appropriate? > > > > Thoughts? > > > > Thanks! > > > > Regards, > > Kevin > --000000000000d2854a0572764d20--