From dev-return-96674-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Aug 2 11:27:25 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 865E2180629 for ; Thu, 2 Aug 2018 11:27:24 +0200 (CEST) Received: (qmail 20926 invoked by uid 500); 2 Aug 2018 09:27:23 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 20912 invoked by uid 99); 2 Aug 2018 09:27:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Aug 2018 09:27:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 302A01A0EC5 for ; Thu, 2 Aug 2018 09:27:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.112 X-Spam-Level: X-Spam-Status: No, score=-0.112 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id R5EbCrJMB6Mb for ; Thu, 2 Aug 2018 09:27:21 +0000 (UTC) Received: from mail-yb0-f176.google.com (mail-yb0-f176.google.com [209.85.213.176]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 72D0F5F19B for ; Thu, 2 Aug 2018 09:27:21 +0000 (UTC) Received: by mail-yb0-f176.google.com with SMTP id l16-v6so560510ybk.11 for ; Thu, 02 Aug 2018 02:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=69i1zsP+vg3JbTNeu2yz1DX/8HV/NahssPvgfECiaac=; b=MjOJwAS/0k8+cDTJDvcVMZBUdSRpsAemWZzqvZ2UIW3qnjHPShhGFOR6xrj4iTG4Xa YXtfhAazrtQL8+W77RKgXv6q4uz/oLYPtrmWN5Cux7ZFJJL9kaNyypE5VeJk2OKDBEed EiwIwOZPEoEJlvh48Pc1u6Y3XmOIYl5pgExmHs9Q9/jj2w/MlHUQcNmsxmwWGMKgN5TN 2DUzZSKob1y3YF3NInB628kbiBtF0QDNr6yi1KSNx44nDkakIjIFZQfE1+xgKLfvc5Vq 5hegPiar3SHjlvhr4MhKZ9eXVg669vSqmpSxr6ADEtcqKYkJmtwaPJ5q9zvPKiM++iNI 0Z7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=69i1zsP+vg3JbTNeu2yz1DX/8HV/NahssPvgfECiaac=; b=jcZ3UkJ6iyfEA9rFgEwtlFCFZyEOcfxTF5MGU5qp22HG+ay5tLVAPc8ex72Ny3hUq2 mV+nPQ3tvgHXPCY4w1pFKGorESipaUf7vr5OB/rqZrK6+OIeZeNRfXc6SgH6hYWtIYGU Z1iZ+hkaCll5lcsx1HjBmXxakCFPhcGJy3CaBXbkKDN9PHYjFIv/EFntHcFTlJOxrSb1 qN9FGYgE4chIlVERCJ+hc9mbTX5lLpcoemmai1ftRFGEiaarsgxgTe8M3+G/PmUhaJMY lXsls6DfPtufCVNSVseYXRh2O6xCGsx7dnVYfgQf/PB+tdBvcOvY7RW99mBrK4Zg33Qc Mp2g== X-Gm-Message-State: AOUpUlHDtS77wbBw/F/Gjbt++YknEk+bH3PTRMb/HNh1MbLQ1vB2LJ0H WXvfQ7CNszagWrgPDyrF7Ti4rZzp5pnj4Vtemb3wJWgy X-Google-Smtp-Source: AAOMgpc/NeAcAdpzOI52CIjANafby0FHfUqGVqlTV3CNivp2hFIMjceIardCke9KVLRt0lwEioaRLP8qNrlAyxHYsMc= X-Received: by 2002:a25:a185:: with SMTP id a5-v6mr848791ybi.205.1533202040744; Thu, 02 Aug 2018 02:27:20 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:38cc:0:0:0:0:0 with HTTP; Thu, 2 Aug 2018 02:27:00 -0700 (PDT) In-Reply-To: References: From: Mickael Maison Date: Thu, 2 Aug 2018 10:27:00 +0100 Message-ID: Subject: Re: [DISCUSS] KIP-351: Add --critical-partitions option to describe topics command To: dev Content-Type: text/plain; charset="UTF-8" What about also adding a --under-minisr-partitions option? That would match the "kafka.server:type=ReplicaManager,name=UnderMinIsrPartitionCount" broker metric and it's usually pretty relevant when investigating issues On Thu, Aug 2, 2018 at 8:54 AM, Kevin Lu wrote: > Hi friends! > > This thread is to discuss KIP-351 > > ! > > I am proposing to add a --critical-partitions option to the describe topics > command that will only list out topic partitions that have 1 ISR left (RF > > 1) as they would be in a critical state and need immediate repartitioning. > > I wonder if the name "critical" is appropriate? > > Thoughts? > > Thanks! > > Regards, > Kevin