From dev-return-95737-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Tue Jul 3 00:55:32 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AFCE1180674 for ; Tue, 3 Jul 2018 00:55:25 +0200 (CEST) Received: (qmail 68852 invoked by uid 500); 2 Jul 2018 22:55:24 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 68839 invoked by uid 99); 2 Jul 2018 22:55:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jul 2018 22:55:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 57E2CD136B for ; Mon, 2 Jul 2018 22:55:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.888 X-Spam-Level: * X-Spam-Status: No, score=1.888 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id T6r6zrb0bDta for ; Mon, 2 Jul 2018 22:55:21 +0000 (UTC) Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com [209.85.218.47]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 0CD215F41A for ; Mon, 2 Jul 2018 22:55:21 +0000 (UTC) Received: by mail-oi0-f47.google.com with SMTP id c6-v6so101258oiy.0 for ; Mon, 02 Jul 2018 15:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=k944OrKLp6jKz9HivKopH2UDi9fdaPizFWz7WhFEdzw=; b=SlxQ09LCC4utpIwzJyHoCJSOynQXxFCNVU629cm/S+aoKiuFEtRt6tsMXBIesgEGpD xJgsoSSkgpe4ANd4bNm0WLmHR6Z+RnyBk9/D7rQ2eFnvhiK7psZ+DLB5D2j4m9SNWeH6 WTlZMxXuOBLrjXcpkcNl3owbDUjF7PqYWz3A747lDP48/5aYo+cL4crSwWFWescJ9ac4 GLmbyNV3S/KXX10QyRyKhTaVCFXwm52dRTc5muJNbJ3/4JOGqO+Nd7jg2YeLZOJ/lp+R pmJyGEnub7CA0nd7R8nJLAlRqfQTuGv6xeJqJyGT9PDlHnF8fsvdTVv9XVTXen/fZSWY 2vtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=k944OrKLp6jKz9HivKopH2UDi9fdaPizFWz7WhFEdzw=; b=uPKrW3IhjWdEcZoXCAyAkje7TSymdbzuRtbGrIIkjIscXdTp78g94HH0rX074aw3P0 z/po0HI59B6O0R3oNw0N3zsLnMMJ6l8BcE4o4H6WY1GRYnTykxROqQMCVMJrsx+qm+oT oyfNJ/Rj/DLXirWe8BAuTWzIk45gdh5NyFr43vIjj/7EStS11Z0zn0cxqRorrflfDtAH hqNpVdguvCvPfytWayT8vOPX4V6Qsgu21gmetyWZMCSP86tp5xVLNoT9rFUMjHsKlOoD LqxZUw89hsVlml7lO0JT6BUhjdSQ3j5vHPPw78etzFGtbuxtY83K5EdSumUf+ZWeNUY4 BJsQ== X-Gm-Message-State: APt69E3scs7gTB3T9y6Hy4PwXC0XD2aDyTjNrdgArO4DgWY3gO/bXPuA 5tRFICoxTb2yQd848MZ1NIw18s0QemIb/5QrzmE= X-Google-Smtp-Source: AAOMgpepUCYmjTue69tzSxcPh8ZJP5vbWY42xuWDpoKm2kcI6xErjBuUwGLGbSmAwX+EfVnwu/saGk39+OLX/Gvs8cc= X-Received: by 2002:aca:f516:: with SMTP id t22-v6mr19102466oih.56.1530572119358; Mon, 02 Jul 2018 15:55:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:4355:0:0:0:0:0 with HTTP; Mon, 2 Jul 2018 15:55:18 -0700 (PDT) In-Reply-To: <09872787-bbb4-c369-0426-8b4a98cf6514@confluent.io> References: <4db89f28-1d40-63f5-bab2-76a32257edc1@confluent.io> <09872787-bbb4-c369-0426-8b4a98cf6514@confluent.io> From: Guozhang Wang Date: Mon, 2 Jul 2018 15:55:18 -0700 Message-ID: Subject: Re: [VOTE] KIP-330: Add retentionPeriod in SessionBytesStoreSupplier To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="0000000000007a435405700c1708" --0000000000007a435405700c1708 Content-Type: text/plain; charset="UTF-8" +1 from myself as well. I'm closing this thread with the tally below: binding +1: 3 (Damian, Matthias, myself) non-binding +1: 3 (Ted, Bill, John) Thanks for everyone's votes! Guozhang On Fri, Jun 29, 2018 at 1:15 PM, Matthias J. Sax wrote: > Thx. That makes sense. Just want to make sure the KIP clearly covers it. > > > +1 (binding) > > > I am only +1 because I think that there are no users customizing a > session store supplier. This KIP goes into 2.1 what is a minor release > that should not contain any breaking changes. We need to be careful with > changes like this and should try to avoid them. > > > -Matthias > > > On 6/29/18 1:02 PM, Guozhang Wang wrote: > > Thanks Matthias, thanks for the comments! Ack on all of them and have > > updated the wiki: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 330:+Add+retentionPeriod+in+SessionBytesStoreSupplier > > > > > > Regarding the impact of this KIP, here's what I'm thinking: > > > > 1. For users of DSL, with customized session store, they need to pass in > > that SessionBytesStoreSupplier into Materialized, and hence need to > always > > customize that interface and hence be impacted. > > 2. For users of PAPI, they will be addStore with a `StoreBuilder`. Note > > that users can either customize the SessionBytesStoreSupplier and pass > into > > `Stores#persistentSessionStore`, or they can go directly instantiate the > > `StoreBuilder` interface. For the latter case, they are not impacted. > > > > Does that make sense to you? > > > > Guozhang > > > > > > On Fri, Jun 29, 2018 at 10:44 AM Matthias J. Sax > > wrote: > > > >> The KIP says: > >> > >>> In WindowBytesStoreSupplier, we will add: > >> > >> Should it be `SessionBytesStoreSupplier` ? > >> > >> > >> What do you mean by > >> > >>> Users customizing the SessionBytesStoreSupplier should not implement > >> this function. > >> > >> From my understanding, this is a breaking change for all users > >> implementing a custom `session window store`. I would expect that there > >> are very few users but the KIP should state this clearly as a breaking > >> API change. > >> > >> > >> Nit: the JIRA link seems to be wrong. > >> > >> > >> -Matthias > >> > >> On 6/28/18 10:12 AM, John Roesler wrote: > >>> +1 > >>> > >>> On Thu, Jun 28, 2018 at 4:39 AM Damian Guy > wrote: > >>> > >>>> +1 > >>>> > >>>> On Thu, 28 Jun 2018 at 02:16 Ted Yu wrote: > >>>> > >>>>> +1 > >>>>> > >>>>> On Wed, Jun 27, 2018 at 4:40 PM, Bill Bejeck > >> wrote: > >>>>> > >>>>>> +1 > >>>>>> > >>>>>> -Bill > >>>>>> > >>>>>> On Wed, Jun 27, 2018 at 7:39 PM Guozhang Wang > >>>>> wrote: > >>>>>> > >>>>>>> Hello folks, > >>>>>>> > >>>>>>> I'd like to start a voting thread on KIP-330. I've intentionally > >>>>> skipped > >>>>>>> the discuss phase since it is a pretty straight-forward public API > >>>>> change > >>>>>>> and should actually be added since day one. The bug fix of > KAFKA-7071 > >>>>>>> helped us to discover this overlook. > >>>>>>> > >>>>>>> > >>>>>>> -- > >>>>>>> -- Guozhang > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > >> > > > > -- -- Guozhang --0000000000007a435405700c1708--