From dev-return-95761-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Tue Jul 3 20:17:45 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B6084180632 for ; Tue, 3 Jul 2018 20:17:44 +0200 (CEST) Received: (qmail 65886 invoked by uid 500); 3 Jul 2018 18:17:43 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 65872 invoked by uid 99); 3 Jul 2018 18:17:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jul 2018 18:17:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 46CB31A0442 for ; Tue, 3 Jul 2018 18:17:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.969 X-Spam-Level: * X-Spam-Status: No, score=1.969 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=confluent-io.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Rr884rqyO0r1 for ; Tue, 3 Jul 2018 18:17:40 +0000 (UTC) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 68DE45F4A2 for ; Tue, 3 Jul 2018 18:17:40 +0000 (UTC) Received: by mail-wm0-f66.google.com with SMTP id 69-v6so3237218wmf.3 for ; Tue, 03 Jul 2018 11:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=confluent-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=1m4OACWsdAwVJjvJhtEv+Nbq0Fn+evEQ/vcTv8UytVA=; b=ibgcvt5LODa8k67zn+TQDTrItAasgFzTknRwbVOrzyDt36MlgoVogszG49QyPQt3uO 8B8GL03ZMBet9L0fXj/z6KgTMM+yFmi062Wl7gcz1S2v286cDe0bQqa87/k8DtE6fa4N 0HkiQv6EsG8m2yFR+PQfZjX84gmjZLsrSw51J8PhzqCp9hGaGG6B//6EpfaJqW45CuUf WKa2MVpaRfXA6KZQQq/o7dN+vcGuq44NEArCU9Menmo6BM3PGntnCRYJ9O/+2yPcogal aUAEcnZrlu0Uf50avt6HEhZjsXFPN5O3lI0jEGKVvphDY2Eux/UrcoUMLoLDPHvCQ0xp yjGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=1m4OACWsdAwVJjvJhtEv+Nbq0Fn+evEQ/vcTv8UytVA=; b=AnnrDAraE+QkcCD6WRBptNuLj+Hr8pJcx3u3Sp3Upl2xHfXCCEx/mOxZtJSpN0215e Q18SErSstWDUhFyeaHekRhLAVDG5noTE81C65Sjek1DscxRB9WcUKVv9SYcSPSsPzJBu 1+JzAJLZ57GzG2j6ddgJa5pVJEevIAwttPJmpYsWqRBh6QK+ZZWBIaLvWjWOWUkuV4Fw zBTJECizMLIagF4zbLt2f0K1RTBU1WAZemibW57pXxmaLtlwMnjIZ0L6uoCLi7C0TLOP jEZHsEeUErcfIwHeGnnFkgzE982GfRWXnrRP98eiBPvvCF5I+8zloIz+FmxtgUief1Hi 3cVg== X-Gm-Message-State: APt69E1zGPKs3bE3GqVw/AQDZj8EKn95EgLsBYTwqR6CkkRKNwyE8YoE 65DG0O10TIH0b6ScfLSARkrZ0Qy83kPBEDuwgR5mZCMH X-Google-Smtp-Source: AAOMgpdAVZYJGAQc9KgFVHdN4pr69wkb8ZIhdXwSohObOu/hrM+qahfmLMKyLhHw/ONmfhUQvEn1MH6rkNXe7AGnuJs= X-Received: by 2002:a1c:a103:: with SMTP id k3-v6mr11824021wme.161.1530641859816; Tue, 03 Jul 2018 11:17:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: John Roesler Date: Tue, 3 Jul 2018 13:17:28 -0500 Message-ID: Subject: Re: [DISCUSS] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="0000000000005556b005701c548a" --0000000000005556b005701c548a Content-Type: text/plain; charset="UTF-8" Hi again, Chia-Ping, Thanks! I took a look at it, and it seems like a good change to me. I don't know if it will generate much discussion, so I recommend just letting it steep for another day or two and then moving on to a vote if no one else chimes in. Just really scraping my mind for concerns to investigate... This change won't break source compatibility, but will it affect binary compatibility? For example, if I compile my application against Kafka 2.0, for example, and then swap in the Kafka jar containing your change on my classpath at run time, will it still work? I think it should be binary compatible, assuming Oracle didn't do anything crazy, since all the method references would be the same. It might we worth an experiment, though. Thanks, -John On Mon, Jul 2, 2018 at 9:29 PM Chia-Ping Tsai wrote: > > Can you provide a link, please? > > Pardon me. I put the page in the incorrect location. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde > > Cheers, > Chia-Ping > > On 2018/07/02 19:45:19, John Roesler wrote: > > Hi Chia-Ping, > > > > I couldn't find KIP-331 in the list of KIPs ( > > > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals > > ). > > > > Can you provide a link, please? > > > > Thanks, > > -John > > > > On Sun, Jul 1, 2018 at 11:33 AM Chia-Ping Tsai > wrote: > > > > > hi folks, > > > > > > KIP-331 is waiting for any suggestions, feedback and reviews. The main > > > purpose of the KIP-331 is to add empty implementations to the close() > and > > > configure() so as to user can write less code to develop custom > Serialzier, > > > Deserializer and Serde. > > > > > > Cheers, > > > Chia-Ping > > > > > > --0000000000005556b005701c548a--