From dev-return-95707-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Mon Jul 2 16:41:47 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 53774180674 for ; Mon, 2 Jul 2018 16:41:47 +0200 (CEST) Received: (qmail 42622 invoked by uid 500); 2 Jul 2018 14:41:41 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 42610 invoked by uid 99); 2 Jul 2018 14:41:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jul 2018 14:41:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 385C51852CF for ; Mon, 2 Jul 2018 14:41:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.889 X-Spam-Level: * X-Spam-Status: No, score=1.889 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id NjErLVvwuiTe for ; Mon, 2 Jul 2018 14:41:38 +0000 (UTC) Received: from sonic308-10.consmr.mail.ne1.yahoo.com (sonic308-10.consmr.mail.ne1.yahoo.com [66.163.187.33]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 502F05F434 for ; Mon, 2 Jul 2018 14:41:38 +0000 (UTC) X-YMail-OSG: aTkz6XMVM1m9Tn8ixPqZd5dyY2EoTt0P8y8RwkCxlKBYm6HQeE2pEcAy7IHEiOE t9G7poCrzWaWMNS0GvScdwlVUW3NENKvpuMVt2qUubtMLn7XECuebjDKVaUVy0hx.YZNfJGnxkvG 1PqAld5veYbwm2vw2WJ9xU4SrJ3YdSgZ9yX0nGx9p1K5DcUggveBewcBEXndpGXN0ixtzIOKN7jz nfeJOWJioJCs9Ws8OQSP0Oc.RLyVZ6ptsJbqm1.hIt9.GDrICpzRs88eEU5iJuKQ439srdjuGqyS 2v6NEYN4XBc_VoujJD2ORPky_Uc30YhtnbF6cA4saR.DxnU_WEr5AA6FkqNpQCSfueUEuYQBgYiz xp5UXannPBfCVK1JPwKvHrs_joff_.LkAtyCP1zkX.sEvF_GaWQ3tcJyjrpPD.7Qv2ntUENW9XTE U6MOoyTE3xIZLwb4wUoL1ZdRHtVW1Zam9.sZ_bFVG96YcMazMhvrT08D8oRdLVdgFwooKd_oa.N_ 6tYSRMfMaARn5LWmo_vmHbioZ_68bj2dVzhOD51yUYlpIB5dL5_sfg4no2gUyDpO04ebiWTPai0m 4vTDB_Yif.zkCp3L3Jv1OTFpBDqgUx4FXHJl6w.jIxWg6lEoSqUqGdX9nT6Gsy5rnCkceQhbAO_w s0EWfEc3bk7kvt0jYoq5aZOgywO9i0TAxovDhgDUht8_zGfckUBi7jnAdgrh9LcrxKJiDFNgBubF EyzG3xPaUgcZ5uH7s32IMndNpGX2AhlnA4MA3IdI0YQ6K05SnM3Vru9n4h9O3O92OVyg1NoYWzaV rNlxdm8imq4bgK8L0OT0q3HCcszFGlfe30tjyLXXv.BUzgbUjaAw6TvmsWdeVxtUbNQOOtbSk.C0 5.1GKJp3kUyTkwZtIoEU9UCdmTOmxFJRtSmXMrPrJ Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Mon, 2 Jul 2018 14:41:37 +0000 Date: Mon, 2 Jul 2018 14:41:35 +0000 (UTC) From: =?UTF-8?Q?Lu=C3=ADs_Cabral?= To: dev Message-ID: <1632702726.1447992.1530542495515@mail.yahoo.com> In-Reply-To: <1342089574.1370104.1530532788665@mail.yahoo.com> References: <387827552.3995666.1530187019111.ref@mail.yahoo.com> <387827552.3995666.1530187019111@mail.yahoo.com> <1698482681.4040834.1530189502699@mail.yahoo.com> <1342089574.1370104.1530532788665@mail.yahoo.com> Subject: Re: [VOTE] KIP-280: Enhanced log compaction MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_1447991_1542826761.1530542495513" X-Mailer: WebService/1.1.12062 YMailNorrin Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36 ------=_Part_1447991_1542826761.1530542495513 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Guozhang, You are right that it is not straightforward to add a dependent property va= lidation.=C2=A0 Though it is possible to re-design it to allow for this, that effort would = be better placed under its own KIP, if it really becomes useful for other p= roperties as well. Given this, the fallback-to-offset behaviour currently documented will be u= sed. Also, while analyzing this, I noticed that the existing compaction properti= es only exist globally, and not per topic.=C2=A0 I don't understand why this is, but it again feels like something out of sc= ope for this KIP. Given this, the KIP was updated to only include the global configuration pr= operties, removing the per-topic configs. I'll soon update the PR according to the documentation, but I trust the KIP= doesn't need that to close, right? Cheers, Luis On Monday, July 2, 2018, 2:00:08 PM GMT+2, Lu=C3=ADs Cabral wrote: =20 =20 Hi Guozhang, At the moment the KIP has your vote, Matthias' and Ted's. Should I ask someone else to have a look? Cheers, Luis =C2=A0 =C2=A0 On Monday, July 2, 2018, 12:16:48 PM GMT+2, Mickael Maison wrote:=C2=A0=20 =20 +1 (non binding). Thanks for the KIP! On Sat, Jun 30, 2018 at 12:26 AM, Guozhang Wang wrote: > Hi Luis, > > Regarding the minor suggest, I agree it would be better to make it as > mandatory, but it might be a bit tricky because it is a conditional > mandatory one depending on the other config's value. Would like to see yo= ur > updated PR. > > Regarding the KIP itself, both Matthias and myself can recast our votes t= o > the updated wiki, while we still need one more committer to vote accordin= g > to the bylaws. > > > Guozhang > > On Thu, Jun 28, 2018 at 5:38 AM, Lu=C3=ADs Cabral > wrote: > >>=C2=A0 Hi, >> >> Thank you all for having a look! >> >> The KIP is now updated with the result of these late discussions, though= I >> did take some liberty with this part: >> >> >>=C2=A0 =C2=A0 - If the "compaction.strategy.header" configuration is not = set (or is >> blank), then the compaction strategy will fallback to "offset"; >> >> >> Alternatively, we can also set it to be a mandatory property when the >> strategy is "header" and fail the application to start via a config >> validation (I would honestly prefer this, but its up to your taste). >> >> Anyway, this is now a minute detail that can be adapted during the final >> stage of this KIP, so are you all alright with me changing the status to >> [ACCEPTED]? >> >> Cheers, >> Luis >> >> >>=C2=A0 =C2=A0 On Thursday, June 28, 2018, 2:08:11 PM GMT+2, Ted Yu < >> yuzhihong@gmail.com> wrote: >> >>=C2=A0 +1 >> >> On Thu, Jun 28, 2018 at 4:56 AM, Lu=C3=ADs Cabral > > >> wrote: >> >> > Hi Ted, >> > Can I also get your input on this? >> > >> > bq. +1 from my side for using `compaction.strategy` with values >> > "offset","timestamp" and "header" and `compaction.strategy.header` >> > -Matthias >> > >> > bq. +1 from me as well. >> > -Guozhang >> > >> > >> > Cheers, >> > Luis >> > >> > >> > >> > > > > -- > -- Guozhang=C2=A0 =20 ------=_Part_1447991_1542826761.1530542495513--