kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (KAFKA-5739) Rewrite KStreamPeekTest at processor level avoiding driver usage
Date Mon, 04 Jun 2018 05:45:00 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guozhang Wang resolved KAFKA-5739.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

This is already fixed in trunk, coming in 2.0.0

> Rewrite KStreamPeekTest at processor level avoiding driver usage
> ----------------------------------------------------------------
>
>                 Key: KAFKA-5739
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5739
>             Project: Kafka
>          Issue Type: Test
>          Components: streams
>            Reporter: Paolo Patierno
>            Assignee: Paolo Patierno
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> Hi,
> as already done for the {{KStreamPrintTest}} we could remove the usage of {{KStreamTestDriver}}
even in the {{KStreamPeekTest}} and testing it at processor level not at stream level.
> My proposal is to :
> * create the {{KStreamPeek}} instance providing the action which fill a collection as
already happens today
> * testing for both {{forwardDownStream}} values true and false
> * using the {{MockProcessorContext}} class for overriding the {{forward}} method filling
a streamObserved collection as happens today {{forwardDownStream}} is true; checking that
the {{forward}} isn't called when {{forwardDownStream}} is false (so the test fails)
> Thanks,
> Paolo 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message