kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Viktor Somogyi <viktorsomo...@gmail.com>
Subject Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server
Date Mon, 04 Jun 2018 09:57:29 GMT
Hi Arseniy,

A few comments from me collected in points:

1. Usually the commands use "bootstrap-server" as in singular and not the
plural "bootstrap-servers", so I suggest to keep this functionality.
Otherwise their behavior is still the same.

2. kafka-get-offsets.sh --bootstrap-servers vm:9092 --topics AAA,ZZZ
--partitions 0,1
I think that we could try out one of the "--topics AAA:0-3,ZZZ:1" or
"--topic-partitions AAA:0-3,ZZZ:1" or "--tp AAA:0-3,ZZZ:1" notations so
that asking for specific topic-partitions (or intervals as in AAA) is more
concise. Perhaps we could enable using your originally proposed and one of
these. What do you think?
Also I would be interested in what others think about this notation. I'd
find it useful as we often refer to partitions as "topic-partition" and
this might strengthen this kind of thinking.

Viktor


On Fri, Jun 1, 2018 at 11:32 PM, Arseniy Tashoyan <tashoyan@gmail.com>
wrote:

> Hi,
>
> I have just created KIP that proposes enhancements to GetOffsetShell
> command line tool.
> KIP:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 308%3A+GetOffsetShell%3A+new+KafkaConsumer+API%2C+support+
> for+multiple+topics%2C+minimize+the+number+of+requests+to+server
>
> PR: https://github.com/apache/kafka/pull/3051
>
> Suggestions are welcome.
>
> Regards,
> Arseniy
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message