From dev-return-90657-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Jan 4 00:49:51 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 39A4B18077A for ; Thu, 4 Jan 2018 00:49:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 296F3160C39; Wed, 3 Jan 2018 23:49:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6DB5C160C1B for ; Thu, 4 Jan 2018 00:49:50 +0100 (CET) Received: (qmail 44346 invoked by uid 500); 3 Jan 2018 23:49:49 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 44334 invoked by uid 99); 3 Jan 2018 23:49:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2018 23:49:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6DD961A07E0 for ; Wed, 3 Jan 2018 23:49:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.879 X-Spam-Level: * X-Spam-Status: No, score=1.879 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id i3Kg6PFYjMCi for ; Wed, 3 Jan 2018 23:49:46 +0000 (UTC) Received: from mail-oi0-f49.google.com (mail-oi0-f49.google.com [209.85.218.49]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 1D5BA5F295 for ; Wed, 3 Jan 2018 23:49:45 +0000 (UTC) Received: by mail-oi0-f49.google.com with SMTP id w125so19317oie.7 for ; Wed, 03 Jan 2018 15:49:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=BCJAkjgMb5tdWPQzjOAhlQjuTODhXLV3oKXJ/fqS2rc=; b=i4KRelxz51icRoJtyMeMe4CU/wRNLG2fLNI8bm40EKMsE4qUkDsypdGW1PQsHbLzDg mnf1jzmoNLY4SqmZz7OzT49wbJPVe61e2cC/e6ypiQ8KADQSk4aaaI5NSQxbL77p6EX3 cVTyM54b0kZCX5Ch0vQu0l4BtOJsWjF7oSF3FQEnf/xP8NmF4xM4AiSl+FlxUFKIJJfY ckfI1N5DwCSmhTrXptmPf28glHvkYgGZcAggKjqaXW2I0dzNkYMAhPMa0J4awHBqpSNH 9a3rE7rwjHeijQ1id4P6DdP/r9BijL/M1WKkcM2Hm3Vn2SdbieXsOpcKer5jjKCqGApD FSag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=BCJAkjgMb5tdWPQzjOAhlQjuTODhXLV3oKXJ/fqS2rc=; b=ORRG4qqCjqIC9oyxY0fWL6tnUQA/g21oTmRvZ7NDBPUOyKxw68nBektzgEwFlqVS7j o+SM6IkAJXZCeZ03Et29miJXoMknSyeRhk95C7L5zN7TvW2NaN3Sc48is3uyMgTD+eiG gQYX0jZexTrwwC9GVGTp9L37B7LNXySS16/lGFum6a2wis4mSG6+ygEDDgINVYctEEDc uIJO8wVOLQT1VlHfhEXilrHUXuoXijWLoerXFMl3p3g4D6SkzqPHCDi2ADaax+ZN50e+ RgQDEbr/FV1YiZHbKHJPEhTHcQmKsiguD6BCKHw/+ShrHipBXNb4tc4y1rxYh04gviak ZClg== X-Gm-Message-State: AKGB3mIf4VwYG6Dn7jGlsNS9rAM/5GWRpHrTWkXg0Ndn/1P/9mNSXNSE gYZRcD6nWo+3cQFODcTzZGi9B/omRuqBAyvz2Ue76A== X-Google-Smtp-Source: ACJfBoteq1CckzRm2QH10F71CWCUWGY5k6pwkctCe57FrV7fKiRNqOrnzVikGH9/VSlmYAktDdfkn0dpc96DmMH3SSc= X-Received: by 10.202.170.76 with SMTP id t73mr1640662oie.298.1515023383509; Wed, 03 Jan 2018 15:49:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.46.141 with HTTP; Wed, 3 Jan 2018 15:49:42 -0800 (PST) In-Reply-To: <086aad8d-2f45-fe6b-b377-75c5c0f5a97b@confluent.io> References: <086aad8d-2f45-fe6b-b377-75c5c0f5a97b@confluent.io> From: Richard Yu Date: Wed, 3 Jan 2018 15:49:42 -0800 Message-ID: Subject: Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="001a113cd4fc99c1930561e7de8c" --001a113cd4fc99c1930561e7de8c Content-Type: text/plain; charset="UTF-8" There are 3 binding votes and 2 nonbinding votes in favor of KIP-239. Binding: Guozhang Wang Damian Guy Ewen Cheslack-Postava Nonbinding: Matthias J. Sax Bill Bejeck This would close this voting thread. On Tue, Jan 2, 2018 at 10:24 PM, Matthias J. Sax wrote: > @Richard: you can close this vote thread with a summary as usual and > update the KIP wiki page accordingly. > > > -Matthias > > On 1/2/18 9:57 PM, Richard Yu wrote: > > A subsequent PR has already been created: > > https://github.com/apache/kafka/pull/4340/ > > It should be seen on the JIRA. > > > > > > > > On Tue, Jan 2, 2018 at 9:51 PM, Ewen Cheslack-Postava > > > wrote: > > > >> Oh, the KIP passes w/ the required votes. My comment was just on > >> implementation details. I will leave comments about that up to the > >> subsequent PR and to the Kafka Streams folks that are much better suited > >> than me to comment on them :) > >> > >> -Ewen > >> > >> On Tue, Jan 2, 2018 at 9:28 PM, Richard Yu > >> wrote: > >> > >>> After investigation, I have found that the > >>> InternalStreamsBuilder#globalTable method is the only instance where > the > >>> constructor for GlobalKTableImpl is called. > >>> The KTableValueGetterSupplier parameter used in this particular > >> constructor > >>> is an instance of KTableSourceValueGetterSupplier. Hence, your > >> requirement > >>> is satisfied. > >>> > >>> Since this is the vote thread, if you have further comments, please > >> comment > >>> on the pull request. > >>> > >>> On Tue, Jan 2, 2018 at 6:38 PM, Ewen Cheslack-Postava < > ewen@confluent.io > >>> > >>> wrote: > >>> > >>>> +1 binding > >>>> > >>>> The idea seems reasonable. Looking at it implementation-wise, seems > >> there > >>>> is a bit of awkwardness because GlobalKTableImpl uses a > >>>> KTableValueGetterSupplier which seems to possibly have multiple > stores, > >>> but > >>>> maybe using the more specific KTableSourceValueGetterSupplier > >>>> implementation instead can resolve that. > >>>> > >>>> -Ewen > >>>> > >>>> On Mon, Jan 1, 2018 at 6:22 PM, Ted Yu wrote: > >>>> > >>>>> Gentle reminder: one more binding vote is needed for the KIP to pass. > >>>>> > >>>>> Cheers > >>>>> > >>>>> On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy > >>>> wrote: > >>>>> > >>>>>> +1 > >>>>>> > >>>>>> On Wed, 20 Dec 2017 at 21:09 Ted Yu wrote: > >>>>>> > >>>>>>> Ping for more (binding) votes. > >>>>>>> > >>>>>>> The pull request is ready. > >>>>>>> > >>>>>>> On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang < > >>> wangguoz@gmail.com> > >>>>>>> wrote: > >>>>>>> > >>>>>>>> +1 (binding), thanks! > >>>>>>>> > >>>>>>>> On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu > >>>>> wrote: > >>>>>>>> > >>>>>>>>> Hi, > >>>>>>>>> Here is the discussion thread: > >>>>>>>>> > >>>>>>>>> http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj= > >>>>>>>>> Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable > >>>>>>>>> > >>>>>>>>> Please vote on this KIP. > >>>>>>>>> > >>>>>>>>> Thanks > >>>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> -- > >>>>>>>> -- Guozhang > >>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > > > > --001a113cd4fc99c1930561e7de8c--