Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
MIME-Version: 1.0
In-Reply-To: <CAA9QSJKMyU2TKXUy9583Uub3TDWn-MR7xKV0Z2DGN5vLo8FVTg@mail.gmail.com>
References: <CAOJcB39WAx812v00=mOvFJk2DG05tLFcXoLrCDGzGfvfHkK4ew@mail.gmail.com>
 <CALte62xoj9jX_imaqNckMZztiJNv1kS1D3_1=d-vNe9oB1-hhA@mail.gmail.com>
 <CAMd5YsxLvgAQEcuKGaySeWg-2d=CrBcg8dDJeKznFKzHNmkcwg@mail.gmail.com> <CAA9QSJKMyU2TKXUy9583Uub3TDWn-MR7xKV0Z2DGN5vLo8FVTg@mail.gmail.com>
From: Jun Rao <jun@confluent.io>
Date: Tue, 2 Jan 2018 14:58:36 -0800
Message-ID: <CAFc58G_Zt90UvCLfKavF=6c+wduJ9c2qzsZSrL0hNGDORp240g@mail.gmail.com>
Subject: Re: [VOTE] KIP-226 - Dynamic Broker Configuration
To: dev@kafka.apache.org
Content-Type: multipart/alternative; boundary="f403045ed7a0fbd6150561d309d5"
archived-at: Tue, 02 Jan 2018 22:58:44 -0000

--f403045ed7a0fbd6150561d309d5
Content-Type: text/plain; charset="UTF-8"

Hi, Rajini,

Thank for the KIP. +1. Just a couple of minor comments below.


50. config.secret.*: Could you document how the encryption/decryption of
passwd work? In particular, how do we support changing config.secret?

51. At the topic level, we also have leader.replication.throttled.replicas
and follower.replication.throttled.replicas. Should they be dynamically
configurable?

Jun


On Tue, Dec 12, 2017 at 9:24 AM, Gwen Shapira <gwen@confluent.io> wrote:

> +1 (binding). Thank you for leading this, Rajini.
>
> On Tue, Dec 12, 2017 at 8:35 AM Tom Bentley <t.j.bentley@gmail.com> wrote:
>
> > +1 (nonbinding)
> >
> > On 12 December 2017 at 15:34, Ted Yu <yuzhihong@gmail.com> wrote:
> >
> > > +1
> > >
> > > On Tue, Dec 12, 2017 at 5:44 AM, Rajini Sivaram <
> rajinisivaram@gmail.com
> > >
> > > wrote:
> > >
> > > > Since there are no more outstanding comments, I would like to start
> > vote
> > > > for KIP-226:
> > > >
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > 226+-+Dynamic+Broker+Configuration
> > > >
> > > >
> > > > The KIP enables dynamic update of commonly updated broker
> configuration
> > > > options to avoid expensive restarts.
> > > >
> > > > Thank you,
> > > >
> > > > Rajini
> > > >
> > >
> >
>

--f403045ed7a0fbd6150561d309d5--