Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
MIME-Version: 1.0
In-Reply-To: <CAKtxd0dxSyJ49CmbpmBv13Q01D2nsa6-p5ub2761fPQ8b6fFHQ@mail.gmail.com>
References: <CALte62w3x+eZ6Z2xKzP0wysu8XESnzpgN9ropFKB-_Eecut0GA@mail.gmail.com>
 <CAHwHRrXyzCbHXUJMHZgzgm+ROosdRJMM2MLyKNU1nwUzmVudfw@mail.gmail.com>
 <CALte62yCAs=q7k3sZH=2Te0yNZbc+3fE0xC3WqhGAc3MhrtNaA@mail.gmail.com>
 <CAJikTEVB8o7A8xfGUafDLVy=kBp70gWr+1jMbMZRxme6Gi-7kQ@mail.gmail.com>
 <CALte62wcT3dv_H2BNHMeXkd1pB_knP2is6PtD8r-hfE+c2FRtg@mail.gmail.com>
 <CAE1jLMOZtwXy1udE7BV=bu1_aSzRE=p_PjS7EBirZ-=MC05RrA@mail.gmail.com> <CAKtxd0dxSyJ49CmbpmBv13Q01D2nsa6-p5ub2761fPQ8b6fFHQ@mail.gmail.com>
From: Ewen Cheslack-Postava <ewen@confluent.io>
Date: Tue, 2 Jan 2018 21:51:37 -0800
Message-ID: <CAE1jLMPLq=VAbcYYvcp4RT5MzX1K0YSH5ZXSXUEt4=SB0k1f7Q@mail.gmail.com>
Subject: Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
To: dev@kafka.apache.org
Content-Type: multipart/alternative; boundary="089e082f8d7c161dc40561d8cf8c"
archived-at: Wed, 03 Jan 2018 05:51:46 -0000

--089e082f8d7c161dc40561d8cf8c
Content-Type: text/plain; charset="UTF-8"

Oh, the KIP passes w/ the required votes. My comment was just on
implementation details. I will leave comments about that up to the
subsequent PR and to the Kafka Streams folks that are much better suited
than me to comment on them :)

-Ewen

On Tue, Jan 2, 2018 at 9:28 PM, Richard Yu <yohan.richard.yu@gmail.com>
wrote:

> After investigation, I have found that the
> InternalStreamsBuilder#globalTable method is the only instance where the
> constructor for GlobalKTableImpl is called.
> The KTableValueGetterSupplier parameter used in this particular constructor
> is an instance of KTableSourceValueGetterSupplier. Hence, your requirement
> is satisfied.
>
> Since this is the vote thread, if you have further comments, please comment
> on the pull request.
>
> On Tue, Jan 2, 2018 at 6:38 PM, Ewen Cheslack-Postava <ewen@confluent.io>
> wrote:
>
> > +1 binding
> >
> > The idea seems reasonable. Looking at it implementation-wise, seems there
> > is a bit of awkwardness because GlobalKTableImpl uses a
> > KTableValueGetterSupplier which seems to possibly have multiple stores,
> but
> > maybe using the more specific KTableSourceValueGetterSupplier
> > implementation instead can resolve that.
> >
> > -Ewen
> >
> > On Mon, Jan 1, 2018 at 6:22 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> >
> > > Gentle reminder: one more binding vote is needed for the KIP to pass.
> > >
> > > Cheers
> > >
> > > On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <damian.guy@gmail.com>
> > wrote:
> > >
> > > > +1
> > > >
> > > > On Wed, 20 Dec 2017 at 21:09 Ted Yu <yuzhihong@gmail.com> wrote:
> > > >
> > > > > Ping for more (binding) votes.
> > > > >
> > > > > The pull request is ready.
> > > > >
> > > > > On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <
> wangguoz@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > +1 (binding), thanks!
> > > > > >
> > > > > > On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yuzhihong@gmail.com>
> > > wrote:
> > > > > >
> > > > > > > Hi,
> > > > > > > Here is the discussion thread:
> > > > > > >
> > > > > > > http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> > > > > > > Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
> > > > > > >
> > > > > > > Please vote on this KIP.
> > > > > > >
> > > > > > > Thanks
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > -- Guozhang
> > > > > >
> > > > >
> > > >
> > >
> >
>

--089e082f8d7c161dc40561d8cf8c--