Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore
To: dev@kafka.apache.org
References: <CANoR8UK0rrCB8E1hRzTZLRHUPgmXwfoR+_HjrcfQe8Vyj-5u_g@mail.gmail.com>
 <f2b9bb72-97af-8f39-935e-dd800a0abc7f@confluent.io>
 <CAF7WS+oYsz8tCZxLNE+ujth-fWgW=T_KWZL-N=jVrYXj6k9LJw@mail.gmail.com>
 <CALte62x4kubxhXQPR3RWGgfGsG8Zy_nOvXsgMUtxQygXRvCWfA@mail.gmail.com>
 <CAHwHRrVxbfOzJSco0OZyrGqHg=81XVDorQAjQj1d91AQcxqcWQ@mail.gmail.com>
 <CAHwHRrVcKpupydyLA+72p8W-5fcE031nCTZzX5PBAT1sOkTWhQ@mail.gmail.com>
 <CAE1jLMMe7OfsDV5k1QtzxiZqJp_skgjw_J+7XHCniu-F1+WecA@mail.gmail.com>
From: "Matthias J. Sax" <matthias@confluent.io>
Organization: Confluent Inc
Message-ID: <6f4410fa-8dd9-a8e3-97e3-a3e2e5e7b4ed@confluent.io>
Date: Tue, 2 Jan 2018 19:49:32 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <CAE1jLMMe7OfsDV5k1QtzxiZqJp_skgjw_J+7XHCniu-F1+WecA@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="QxRIfB2MHuTf3A7PAl1QJQf7zb8k6XjZj"
archived-at: Wed, 03 Jan 2018 03:49:49 -0000

--QxRIfB2MHuTf3A7PAl1QJQf7zb8k6XjZj
Content-Type: multipart/mixed; boundary="vlyaAaolHWEgfJyllb3uxCUYGJXQai3DW";
 protected-headers="v1"
From: "Matthias J. Sax" <matthias@confluent.io>
To: dev@kafka.apache.org
Message-ID: <6f4410fa-8dd9-a8e3-97e3-a3e2e5e7b4ed@confluent.io>
Subject: Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore
References: <CANoR8UK0rrCB8E1hRzTZLRHUPgmXwfoR+_HjrcfQe8Vyj-5u_g@mail.gmail.com>
 <f2b9bb72-97af-8f39-935e-dd800a0abc7f@confluent.io>
 <CAF7WS+oYsz8tCZxLNE+ujth-fWgW=T_KWZL-N=jVrYXj6k9LJw@mail.gmail.com>
 <CALte62x4kubxhXQPR3RWGgfGsG8Zy_nOvXsgMUtxQygXRvCWfA@mail.gmail.com>
 <CAHwHRrVxbfOzJSco0OZyrGqHg=81XVDorQAjQj1d91AQcxqcWQ@mail.gmail.com>
 <CAHwHRrVcKpupydyLA+72p8W-5fcE031nCTZzX5PBAT1sOkTWhQ@mail.gmail.com>
 <CAE1jLMMe7OfsDV5k1QtzxiZqJp_skgjw_J+7XHCniu-F1+WecA@mail.gmail.com>
In-Reply-To: <CAE1jLMMe7OfsDV5k1QtzxiZqJp_skgjw_J+7XHCniu-F1+WecA@mail.gmail.com>

--vlyaAaolHWEgfJyllb3uxCUYGJXQai3DW
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

It must be two different names, as we add two processor to the topology:
a source processor that only read the data from a topic, and the actual
processor that maintains the global table.


-Matthias

On 1/2/18 7:14 PM, Ewen Cheslack-Postava wrote:
> +1 binding, seems like a nice simplification.
>=20
> Regarding the source and processor name, do they actually need to be un=
ique
> or could they use the same value? Since these use incrementing integers=
, it
> could be nice for debuggability/understanding to have them use the same=

> name if possible instead of generating 2 separate names.
>=20
> -Ewen
>=20
> On Tue, Jan 2, 2018 at 9:12 AM, Guozhang Wang <wangguoz@gmail.com> wrot=
e:
>=20
>> On a side note, could you update the "compatibility and upgrade" secti=
on,
>> that when users start to make code changes to leverage the new API, wh=
at
>> kind of upgrade executions they'd need to do? I feel they need to rena=
me
>> topics / etc.
>>
>> On Tue, Jan 2, 2018 at 9:10 AM, Guozhang Wang <wangguoz@gmail.com> wro=
te:
>>
>>> +1, thanks!
>>>
>>> On Wed, Dec 27, 2017 at 6:01 PM, Ted Yu <yuzhihong@gmail.com> wrote:
>>>
>>>> +1
>>>>
>>>> On Wed, Dec 27, 2017 at 12:15 PM, Bill Bejeck <bbejeck@gmail.com>
>> wrote:
>>>>
>>>>> +1
>>>>>
>>>>> On Wed, Dec 27, 2017 at 3:07 PM, Matthias J. Sax <
>> matthias@confluent.io
>>>>>
>>>>> wrote:
>>>>>
>>>>>> +1
>>>>>>
>>>>>> On 12/26/17 9:00 PM, Panuwat Anawatmongkhon wrote:
>>>>>>> Hi all,
>>>>>>> I would like to start the vote thread.
>>>>>>> This is link for the kip.
>>>>>>>
>>>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-233%
>>>> 3A+Simplify+
>>>>>> StreamsBuilder%23addGlobalStore
>>>>>>>
>>>>>>> Cheers
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> -- Guozhang
>>>
>>
>>
>>
>> --
>> -- Guozhang
>>
>=20


--vlyaAaolHWEgfJyllb3uxCUYGJXQai3DW--

--QxRIfB2MHuTf3A7PAl1QJQf7zb8k6XjZj
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQJKBAEBCgA0FiEEFpAnjJ4fbvgzKNUmjQjbao0qTDYFAlpMUswWHG1hdHRoaWFz
QGNvbmZsdWVudC5pbwAKCRCNCNtqjSpMNi/dD/4qCoPg0HAxbJmPKVTVrpyqQrkC
gEoIN8o/Ss5tILtHL4j+7nwRzBIVuM5ytWzLGy18g0hc9fdRnh/9gHiNbfKy1ez7
8cHkV+9q4ckvyKHcPW+HEmNdpljMSe/Rk0sldBvuF/95yfzrJ2Nv5ANfmr58sfrt
6Hf1hQ1FyqZCa9LFKsSgJWNmi6kBWfLPRGFOb2pebAZqs6EH1MQ2dXj9R+NVQlSb
+jRYmbPI8RInS/DYlK3HGvF2Y4DgvozQQuwme2o1JbZZYl9WRnsrurJ5b7voqE19
xsu09rzcVtHtbuhelHdBuW251IW/U+FLM/7obZd4MqTixHnu7KjVmkVRX1ZET8wg
y2fqy+RSGdj5T5yX8zYniMt0NWz8n2f1cyrLt4rb2i6J0Y0Bol2KowIT548xobQ1
3MSJ+4ty39xB0f3c0a8uktR7eCEvSFEVg7/2KR4pAi6Qgbpvqwr2VwlLnC9nRvgu
I2v3pY0qDxJIjxfAuKy1RicYwGXbcivhGyp8vWljvQMd2hg3F+edDG+aBrf7Qv8K
dL0LdAe7348zt3DWULiuXz4UQazqcRJWNHRd+g4+APT9cdLKsBlqe7EIzy90KN8A
6svq7Kcy8IW7wmifWeL9rsDFPeMfVAysPH+H5IM4YqiEJ46pm8pDg4iV5dykWkNR
oXHbufPGhodj+BQhWw==
=lnPP
-----END PGP SIGNATURE-----

--QxRIfB2MHuTf3A7PAl1QJQf7zb8k6XjZj--