Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
To: dev@kafka.apache.org
References: <CALte62w3x+eZ6Z2xKzP0wysu8XESnzpgN9ropFKB-_Eecut0GA@mail.gmail.com>
 <CAHwHRrXyzCbHXUJMHZgzgm+ROosdRJMM2MLyKNU1nwUzmVudfw@mail.gmail.com>
 <CALte62yCAs=q7k3sZH=2Te0yNZbc+3fE0xC3WqhGAc3MhrtNaA@mail.gmail.com>
 <CAJikTEVB8o7A8xfGUafDLVy=kBp70gWr+1jMbMZRxme6Gi-7kQ@mail.gmail.com>
 <CALte62wcT3dv_H2BNHMeXkd1pB_knP2is6PtD8r-hfE+c2FRtg@mail.gmail.com>
 <CAE1jLMOZtwXy1udE7BV=bu1_aSzRE=p_PjS7EBirZ-=MC05RrA@mail.gmail.com>
 <CAKtxd0dxSyJ49CmbpmBv13Q01D2nsa6-p5ub2761fPQ8b6fFHQ@mail.gmail.com>
 <CAE1jLMPLq=VAbcYYvcp4RT5MzX1K0YSH5ZXSXUEt4=SB0k1f7Q@mail.gmail.com>
 <CAKtxd0eu1u6YOo7YEiKH4arCESFvBUjVe+=H3Hm7KDAQ07b3yw@mail.gmail.com>
From: "Matthias J. Sax" <matthias@confluent.io>
Organization: Confluent Inc
Message-ID: <086aad8d-2f45-fe6b-b377-75c5c0f5a97b@confluent.io>
Date: Tue, 2 Jan 2018 22:24:59 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <CAKtxd0eu1u6YOo7YEiKH4arCESFvBUjVe+=H3Hm7KDAQ07b3yw@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="Uf1xESPyAXA5l6BhSIFXzzgB6TXMcJ4pI"
archived-at: Wed, 03 Jan 2018 06:25:10 -0000

--Uf1xESPyAXA5l6BhSIFXzzgB6TXMcJ4pI
Content-Type: multipart/mixed; boundary="6mejx2xn3VmiBmjCXsfKd6aDX5BaEtOZT";
 protected-headers="v1"
From: "Matthias J. Sax" <matthias@confluent.io>
To: dev@kafka.apache.org
Message-ID: <086aad8d-2f45-fe6b-b377-75c5c0f5a97b@confluent.io>
Subject: Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
References: <CALte62w3x+eZ6Z2xKzP0wysu8XESnzpgN9ropFKB-_Eecut0GA@mail.gmail.com>
 <CAHwHRrXyzCbHXUJMHZgzgm+ROosdRJMM2MLyKNU1nwUzmVudfw@mail.gmail.com>
 <CALte62yCAs=q7k3sZH=2Te0yNZbc+3fE0xC3WqhGAc3MhrtNaA@mail.gmail.com>
 <CAJikTEVB8o7A8xfGUafDLVy=kBp70gWr+1jMbMZRxme6Gi-7kQ@mail.gmail.com>
 <CALte62wcT3dv_H2BNHMeXkd1pB_knP2is6PtD8r-hfE+c2FRtg@mail.gmail.com>
 <CAE1jLMOZtwXy1udE7BV=bu1_aSzRE=p_PjS7EBirZ-=MC05RrA@mail.gmail.com>
 <CAKtxd0dxSyJ49CmbpmBv13Q01D2nsa6-p5ub2761fPQ8b6fFHQ@mail.gmail.com>
 <CAE1jLMPLq=VAbcYYvcp4RT5MzX1K0YSH5ZXSXUEt4=SB0k1f7Q@mail.gmail.com>
 <CAKtxd0eu1u6YOo7YEiKH4arCESFvBUjVe+=H3Hm7KDAQ07b3yw@mail.gmail.com>
In-Reply-To: <CAKtxd0eu1u6YOo7YEiKH4arCESFvBUjVe+=H3Hm7KDAQ07b3yw@mail.gmail.com>

--6mejx2xn3VmiBmjCXsfKd6aDX5BaEtOZT
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

@Richard: you can close this vote thread with a summary as usual and
update the KIP wiki page accordingly.


-Matthias

On 1/2/18 9:57 PM, Richard Yu wrote:
> A subsequent PR has already been created:
> https://github.com/apache/kafka/pull/4340/
> It should be seen on the JIRA.
>=20
>=20
>=20
> On Tue, Jan 2, 2018 at 9:51 PM, Ewen Cheslack-Postava <ewen@confluent.i=
o>
> wrote:
>=20
>> Oh, the KIP passes w/ the required votes. My comment was just on
>> implementation details. I will leave comments about that up to the
>> subsequent PR and to the Kafka Streams folks that are much better suit=
ed
>> than me to comment on them :)
>>
>> -Ewen
>>
>> On Tue, Jan 2, 2018 at 9:28 PM, Richard Yu <yohan.richard.yu@gmail.com=
>
>> wrote:
>>
>>> After investigation, I have found that the
>>> InternalStreamsBuilder#globalTable method is the only instance where =
the
>>> constructor for GlobalKTableImpl is called.
>>> The KTableValueGetterSupplier parameter used in this particular
>> constructor
>>> is an instance of KTableSourceValueGetterSupplier. Hence, your
>> requirement
>>> is satisfied.
>>>
>>> Since this is the vote thread, if you have further comments, please
>> comment
>>> on the pull request.
>>>
>>> On Tue, Jan 2, 2018 at 6:38 PM, Ewen Cheslack-Postava <ewen@confluent=
=2Eio
>>>
>>> wrote:
>>>
>>>> +1 binding
>>>>
>>>> The idea seems reasonable. Looking at it implementation-wise, seems
>> there
>>>> is a bit of awkwardness because GlobalKTableImpl uses a
>>>> KTableValueGetterSupplier which seems to possibly have multiple stor=
es,
>>> but
>>>> maybe using the more specific KTableSourceValueGetterSupplier
>>>> implementation instead can resolve that.
>>>>
>>>> -Ewen
>>>>
>>>> On Mon, Jan 1, 2018 at 6:22 PM, Ted Yu <yuzhihong@gmail.com> wrote:
>>>>
>>>>> Gentle reminder: one more binding vote is needed for the KIP to pas=
s.
>>>>>
>>>>> Cheers
>>>>>
>>>>> On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <damian.guy@gmail.com>
>>>> wrote:
>>>>>
>>>>>> +1
>>>>>>
>>>>>> On Wed, 20 Dec 2017 at 21:09 Ted Yu <yuzhihong@gmail.com> wrote:
>>>>>>
>>>>>>> Ping for more (binding) votes.
>>>>>>>
>>>>>>> The pull request is ready.
>>>>>>>
>>>>>>> On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <
>>> wangguoz@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> +1 (binding), thanks!
>>>>>>>>
>>>>>>>> On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yuzhihong@gmail.com>
>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>> Here is the discussion thread:
>>>>>>>>>
>>>>>>>>> http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=3D
>>>>>>>>> Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
>>>>>>>>>
>>>>>>>>> Please vote on this KIP.
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> -- Guozhang
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>=20


--6mejx2xn3VmiBmjCXsfKd6aDX5BaEtOZT--

--Uf1xESPyAXA5l6BhSIFXzzgB6TXMcJ4pI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQJKBAEBCgA0FiEEFpAnjJ4fbvgzKNUmjQjbao0qTDYFAlpMdzwWHG1hdHRoaWFz
QGNvbmZsdWVudC5pbwAKCRCNCNtqjSpMNj2+D/9vWljsXdBmGnNTonyzHL0469g1
KjI7LRXtLxnHLtuXR/tuvM+qgxFr9A672T1SzJkWq5vQBrwMjwTMfdx6IvQKfVS/
vkqsF3gAIEcexbZ0J2TxSQAe6J8gNcVhYA8W8y2+/bGGkE+WO3XlXaEjACWSphWt
qViWFwL4n7Yl9U529+81IVckuA/7fzIBXhqF77OljJaNNfWZrlee40Yg078gVZhI
E1cA6V0ZLm62Ix53qjqZdiQUPtxa3nYuFrmf+P3JzF+FpyzH4AIOY/2m5t0mVEVb
YUTWCyNNbTV8JwTCu7G4Ijk45mljASxb11FQakl+I4FEjAeGhLdDgu1wowH8xXih
xlBMKenkzk5soEsaGBctN3WVWM0XRWHM7LBqSHCozu7m9GI0K/rjP4GJ3B5sfhh4
kWSxtBFkokSRtuHj2yYbrFoRH98wtCLwZbyOn/uVPmcv92bDIfWTTPDDZT7kA22H
1Rqx/VOYNIYxm8QIOdRDY1rd53Ihesd655rW5fy7WQohzGx1fFrTzkaElMDOzb5I
ZBRSMiSZhubbz2HH5NggO1tlymzhMtBmxFwMsGIsMlyTdDCeNzQhTJQ9eLIyb8Dl
2tLrf1WA3tiU2wXmGps+AM7s3UkegtwopFCqJ9MdoY2/PUI8hdUoodwlBMAlEIey
cf7/aybhyFIX2cmUVw==
=UMnR
-----END PGP SIGNATURE-----

--Uf1xESPyAXA5l6BhSIFXzzgB6TXMcJ4pI--