kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Richard Yu <yohan.richard...@gmail.com>
Subject Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Date Wed, 03 Jan 2018 05:28:07 GMT
After investigation, I have found that the
InternalStreamsBuilder#globalTable method is the only instance where the
constructor for GlobalKTableImpl is called.
The KTableValueGetterSupplier parameter used in this particular constructor
is an instance of KTableSourceValueGetterSupplier. Hence, your requirement
is satisfied.

Since this is the vote thread, if you have further comments, please comment
on the pull request.

On Tue, Jan 2, 2018 at 6:38 PM, Ewen Cheslack-Postava <ewen@confluent.io>
wrote:

> +1 binding
>
> The idea seems reasonable. Looking at it implementation-wise, seems there
> is a bit of awkwardness because GlobalKTableImpl uses a
> KTableValueGetterSupplier which seems to possibly have multiple stores, but
> maybe using the more specific KTableSourceValueGetterSupplier
> implementation instead can resolve that.
>
> -Ewen
>
> On Mon, Jan 1, 2018 at 6:22 PM, Ted Yu <yuzhihong@gmail.com> wrote:
>
> > Gentle reminder: one more binding vote is needed for the KIP to pass.
> >
> > Cheers
> >
> > On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <damian.guy@gmail.com>
> wrote:
> >
> > > +1
> > >
> > > On Wed, 20 Dec 2017 at 21:09 Ted Yu <yuzhihong@gmail.com> wrote:
> > >
> > > > Ping for more (binding) votes.
> > > >
> > > > The pull request is ready.
> > > >
> > > > On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <wangguoz@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 (binding), thanks!
> > > > >
> > > > > On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yuzhihong@gmail.com>
> > wrote:
> > > > >
> > > > > > Hi,
> > > > > > Here is the discussion thread:
> > > > > >
> > > > > > http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> > > > > > Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
> > > > > >
> > > > > > Please vote on this KIP.
> > > > > >
> > > > > > Thanks
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > -- Guozhang
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message