Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig
 constructors public
To: dev@kafka.apache.org
References: <dec97045-5d4f-e55b-cb21-b04bd9cdc566@confluent.io>
 <CALte62yaQkHteX0KV=FeWc7RJim5A7i2=-FXqsbH-Y=OL3CC=A@mail.gmail.com>
 <OF090EA2A8.4B1DB8F4-ON002581FA.007F7AEF-882581FA.0080FB8E@notes.na.collabserv.com>
 <CAMd5YsxSpSseZQgtjYS8kBbxoXS9jTGjj-DmQwSRsxp99dcQ1g@mail.gmail.com>
 <CAHwHRrVefR_3NvFf6mJ83Rt7VASZtohj=3zF6Lgp-DQj=VHXcg@mail.gmail.com>
 <CAF7WS+pqtd97z=cqdjOdK5pbDv77TEL6jop1O3DLpaz_k4BH_w@mail.gmail.com>
 <CAJDuW=CuYyK7QeBrJHwdLk_6-9uiveTvL5k6p_iukA=6EPNUnw@mail.gmail.com>
From: "Matthias J. Sax" <matthias@confluent.io>
Organization: Confluent Inc
Message-ID: <3571505b-0c54-98ba-11df-2e5045d4678d@confluent.io>
Date: Wed, 20 Dec 2017 17:59:41 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CAJDuW=CuYyK7QeBrJHwdLk_6-9uiveTvL5k6p_iukA=6EPNUnw@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="OSjx1JkA3CwWykWwRgwf8QF8OUwH9Jiwu"
archived-at: Thu, 21 Dec 2017 01:59:49 -0000

--OSjx1JkA3CwWykWwRgwf8QF8OUwH9Jiwu
Content-Type: multipart/mixed; boundary="hFfplkT8BevkymIWjr8cnrr7qb8BPMzG9";
 protected-headers="v1"
From: "Matthias J. Sax" <matthias@confluent.io>
To: dev@kafka.apache.org
Message-ID: <3571505b-0c54-98ba-11df-2e5045d4678d@confluent.io>
Subject: Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig
 constructors public
References: <dec97045-5d4f-e55b-cb21-b04bd9cdc566@confluent.io>
 <CALte62yaQkHteX0KV=FeWc7RJim5A7i2=-FXqsbH-Y=OL3CC=A@mail.gmail.com>
 <OF090EA2A8.4B1DB8F4-ON002581FA.007F7AEF-882581FA.0080FB8E@notes.na.collabserv.com>
 <CAMd5YsxSpSseZQgtjYS8kBbxoXS9jTGjj-DmQwSRsxp99dcQ1g@mail.gmail.com>
 <CAHwHRrVefR_3NvFf6mJ83Rt7VASZtohj=3zF6Lgp-DQj=VHXcg@mail.gmail.com>
 <CAF7WS+pqtd97z=cqdjOdK5pbDv77TEL6jop1O3DLpaz_k4BH_w@mail.gmail.com>
 <CAJDuW=CuYyK7QeBrJHwdLk_6-9uiveTvL5k6p_iukA=6EPNUnw@mail.gmail.com>
In-Reply-To: <CAJDuW=CuYyK7QeBrJHwdLk_6-9uiveTvL5k6p_iukA=6EPNUnw@mail.gmail.com>

--hFfplkT8BevkymIWjr8cnrr7qb8BPMzG9
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

It's tailored for internal usage. I think client constructors don't
benefit from accepting those config objects. We just want to be able to
access the default values for certain parameters.

=46rom a user point of view, it's actually boiler plate code if you pass
in a config object instead of a plain Properties object because the
config object itself is immutable.

I actually create a JIRA to remove the constructors from KafkaStreams
that do accept StreamsConfig for exact this reason:
https://issues.apache.org/jira/browse/KAFKA-6386


-Matthias


On 12/20/17 3:33 PM, Jason Gustafson wrote:
> Hi Matthias,
>=20
> Isn't it a little weird to make these constructors public but not also
> expose the corresponding client constructors that use them?
>=20
> -Jason
>=20
> On Tue, Dec 19, 2017 at 9:30 AM, Bill Bejeck <bbejeck@gmail.com> wrote:=

>=20
>> +1
>>
>> On Tue, Dec 19, 2017 at 12:09 PM, Guozhang Wang <wangguoz@gmail.com>
>> wrote:
>>
>>> +1
>>>
>>> On Tue, Dec 19, 2017 at 1:49 AM, Tom Bentley <t.j.bentley@gmail.com>
>>> wrote:
>>>
>>>> +1
>>>>
>>>> On 18 December 2017 at 23:28, Vahid S Hashemian <
>>> vahidhashemian@us.ibm.com
>>>>>
>>>> wrote:
>>>>
>>>>> +1
>>>>>
>>>>> Thanks for the KIP.
>>>>>
>>>>> --Vahid
>>>>>
>>>>>
>>>>>
>>>>> From:   Ted Yu <yuzhihong@gmail.com>
>>>>> To:     dev@kafka.apache.org
>>>>> Date:   12/18/2017 02:45 PM
>>>>> Subject:        Re: [VOTE] KIP-243: Make ProducerConfig and
>>>> ConsumerConfig
>>>>> constructors public
>>>>>
>>>>>
>>>>>
>>>>> +1
>>>>>
>>>>> nit: via "copy and past" an 'e' is missing at the end.
>>>>>
>>>>> On Mon, Dec 18, 2017 at 2:38 PM, Matthias J. Sax <
>>> matthias@confluent.io>
>>>>> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I want to propose the following KIP:
>>>>>>
>>>>> https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__cwiki.
>>>>> apache.org_confluence_display_KAFKA_KIP-2D&d=3DDwIBaQ&c=3Djf_
>>>>> iaSHvJObTbx-siA1ZOg&r=3DQ_itwloTQj3_xUKl7Nzswo6KE4Nj-
>>>>> kjJc7uSVcviKUc&m=3DJToRX4-HeVsRoOekIz18ht-YLMe-T21MttZTgbxB4ag&s=3D=

>>>>> 6aZjPCc9e00raokVPKvx1BxwDOHyCuKNgtBXPMeoHy4&e=3D
>>>>>
>>>>>> 243%3A+Make+ProducerConfig+and+ConsumerConfig+constructors+public
>>>>>>
>>>>>>
>>>>>> This is a rather straight forward change, thus I skip the DISCUSS
>>>>>> thread and call for a vote immediately.
>>>>>>
>>>>>>
>>>>>> -Matthias
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> -- Guozhang
>>>
>>
>=20


--hFfplkT8BevkymIWjr8cnrr7qb8BPMzG9--

--OSjx1JkA3CwWykWwRgwf8QF8OUwH9Jiwu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQJKBAEBCgA0FiEEFpAnjJ4fbvgzKNUmjQjbao0qTDYFAlo7FY0WHG1hdHRoaWFz
QGNvbmZsdWVudC5pbwAKCRCNCNtqjSpMNrwPD/sEmJIoTBVmauFpZ6+MvjTICv19
USd2NTRQzQa0jTjlmvEVwWOsjaJlHyFrd/kvytjFRZxfIkx+ht+vi7AbhnEBjbq6
OX70DsxoWLFQOBAs6fxtcs9CMREI2DiHIyKBOaM4qDTjfNvlfwTUegHjXnYUpJq0
iNVGq1YpfzCDham37BXmKKlefVc0k/L98fE7xWHYrdd6ddijYqQ2FK/nDOs5xNax
L+ztDAnu7zTLa24CfLNlg3gxzL1VENsQujEz3myh1IM+xTRdV4ZN5tz9AIp4PwIX
3xKU2Q53FuLnri5uvlPCy96z/gAJTdt9Y8l1ex/5HWNydVFXOcU28e5r0NfyZT47
zoybqCXZWjl8rQM64cerAjIMIoepcafsB5HRwH6gy8ZOjyxvT3PpTILPoixLuj0d
h71Ublohdh1lWn8hfYgJ9crde+iSqRnLcXGiuxmHwqaGZx3HSRMXpRYXA+GMl9Hq
r4oXvt4DCL4mBlmClyztqBwlz3z0ZjamyZ/WdiQPp/gX04UIGaweFUYVGpnDfr9u
ilznWvbMg0VD1q0uKw+eZr/p0ROjjawi3/WXOnAShycS+uawqWftsGTmY+Ao+ek6
xbFMQTvQJw+W/pvYBEzmgGw4WKFMSNRtBWprgFxazY3+eM8bnzItmlQKSZ08vVFw
N588qwPJz/2AZDlA6g==
=wGm1
-----END PGP SIGNATURE-----

--OSjx1JkA3CwWykWwRgwf8QF8OUwH9Jiwu--