kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias J. Sax (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (KAFKA-5551) StreamThread should not expose methods for testing
Date Mon, 11 Dec 2017 18:59:01 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Matthias J. Sax resolved KAFKA-5551.
    Resolution: Fixed

> StreamThread should not expose methods for testing
> --------------------------------------------------
>                 Key: KAFKA-5551
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5551
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Matthias J. Sax
> {{StreamsThread}} currently exposes {{createStreamTask()}} and {{createStandbyTask()}}
as {{protected}} in order to inject "test tasks" in unit tests. We should rework this and
make both methods {{private}}. Maybe we can introduce a {{TaskSupplier}} similar to {{KafkaClientSupplier}}
(however, {{TaskSupplier}} should not be public API and be in package {{internal}}).

This message was sent by Atlassian JIRA

View raw message