kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ijuma <...@git.apache.org>
Subject [GitHub] kafka pull request #4007: MINOR: Java 9 version handling improvements
Date Tue, 03 Oct 2017 11:19:02 GMT
GitHub user ijuma opened a pull request:


    MINOR: Java 9 version handling improvements

    - Upgrade Gradle to 4.2.1, which handles Azul Zulu 9's version
    - Add tests to our Java version handling code
    - Refactor the code to make it possible to add tests
    - Rename `isIBMJdk` method to use consistent naming

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka java-9-version-handling-improvements

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4007
commit 1ef63b35c7b1fb5b568f0a71924f3a3483c6eb1b
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2017-10-03T11:16:01Z

    Add tests for java version compatibility methods

commit 236bffc910bd46601715ed1086f5986229b74cb9
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2017-10-03T11:16:33Z

    Rename `Java.isIBMJdk` method to use consistent convention

commit c82ca6b7c522efa4be432ab3f2c67145aa0870d8
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2017-10-03T11:17:01Z

    Update to Gradle 4.2.1



View raw message