Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
From: Paolo Patierno <ppatierno@live.com>
To: "dev@kafka.apache.org" <dev@kafka.apache.org>
Subject: Re: Kafka Streams debugging with "no fluent" API choice
Thread-Topic: Kafka Streams debugging with "no fluent" API choice
Thread-Index: AQHTCrOe+SCiHWQIkkywmURyWmM9UKJvaTEAgAACE5uAAB+GgIAAAgOP
Date: Tue, 1 Aug 2017 14:20:01 +0000
Message-ID: <HE1PR0202MB29062E63356137442C710CEEC9B30@HE1PR0202MB2906.eurprd02.prod.outlook.com>
References: <HE1PR0202MB29068426E7D14E6CE0B84DB4C9B30@HE1PR0202MB2906.eurprd02.prod.outlook.com>
 <CAJikTEVrTxKY+Y9jagytkGuvf8Y3Xu5WUvJwdbx0Bs2XM7n2uA@mail.gmail.com>
 <HE1PR0202MB290608AFD3288CED23EFC039C9B30@HE1PR0202MB2906.eurprd02.prod.outlook.com>,<CAJikTEVwRRrud_kXLc4cXS9MgXYT8QoXF=RVDGcEcADdOvuDfw@mail.gmail.com>
In-Reply-To: <CAJikTEVwRRrud_kXLc4cXS9MgXYT8QoXF=RVDGcEcADdOvuDfw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [Eus3Oq22NrVIJwo3+9z8e+0iAY00sf4v]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;HE1EUR02HT116;7:8O8k2ucDzOTcMOnBZR21BfdIOBPhf2J2O6zCTZGH6hSZMI9ue4tVum6PH5rBnaGF/v7R9k7NJUozSTusVfju8+/tNhL3eqHLfAsXIqb3Q94rhiyPfLsNj1zYXxzb/7t8K6SZ0xmQe2/6F5us+MOKXlfIoe6XeqDtq+dWvqD0QZu/WlYAFNKagSRn7X4gS7sqbRXYljX2Z4khYEOS5UrtA1PC+fz26Io5JOk3I0QUJCW7pQivGBg7xIhTyJUtctn+ciFtkFmARPnLBXb1Ff4o9RPqeu2Etbp8qmKf4Cg0+CIOGN9rMa7yFYHjMlCCnYhoU6Bpqc0KElPdYL5SYKMbHlUBH+sYC6gt4yPN6TNoUuDc1Zf+yEZ3A2xdMUUSoPRxsl8je42k1FMjXCw8xDJzG+qGHc7lHf2FKlIS1DuabZtk2PnVE675wc9fcGugrv20hN5bjQxHHouDfM+OFHIF8YXSsaQd2CYISaQemYtfguZLe9GUHcKbSAj8tM4HZOHDaXcg12xWKHHtVM1gGx0YrqZEoKYmI4wjvfsrLTaWt7a3ChN/F8v902W+icUsxaP9MJ/mOuG5gSgrsjuvsdPpIAs+VvTjYPjou+SxYwfVYHbmdm90joIquX8c2b2SdwooNhc0frmrdt9CH3oQ02K1UP1SDpQ6bF8uTqvvmFqo+vZil5nN/Q/jwYqVOso7rKAJ/RJ/jrJkXkQYeQn/RObt1X1rTj/JuXdvnKji7W+BHjwfa/7hjwLCuUTzIgVnuC6Rr2VQhrkDiD6wMaRIWqVkJA==
x-incomingheadercount: 45
x-eopattributedmessage: 0
x-forefront-antispam-report: EFV:NLI;SFV:NSPM;SFS:(7070007)(98901004);DIR:OUT;SFP:1901;SCL:1;SRVR:HE1EUR02HT116;H:HE1PR0202MB2906.eurprd02.prod.outlook.com;FPR:;SPF:None;LANG:en;
x-ms-office365-filtering-correlation-id: 795e1488-8504-4e43-2f97-08d4d8e865d2
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322377)(1601125374)(1603101448)(1701031045)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:HE1EUR02HT116;
x-ms-traffictypediagnostic: HE1EUR02HT116:
x-exchange-antispam-report-test: UriScan:(134217032509453)(148322886591682)(166708455590820)(31418570063057)(47647156867600)(37052965297144)(116415991822766)(81160342030619)(105182351903845);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(444000031);SRVR:HE1EUR02HT116;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1EUR02HT116;
x-forefront-prvs: 0386B406AA
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_HE1PR0202MB29062E63356137442C710CEEC9B30HE1PR0202MB2906_"
MIME-Version: 1.0
X-OriginatorOrg: live.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2017 14:20:01.7567
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR02HT116
archived-at: Tue, 01 Aug 2017 14:20:14 -0000

--_000_HE1PR0202MB29062E63356137442C710CEEC9B30HE1PR0202MB2906_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hi Damian,


changing the print() method for sure needs a KIP but I guess there is some =
reason we don't know why they decided to not have a fluent API for that.

Regarding my JIRA I don't think a KIP is required, it's just internal stuff=
 ... no ?


Thanks


Paolo Patierno
Senior Software Engineer (IoT) @ Red Hat
Microsoft MVP on Windows Embedded & IoT
Microsoft Azure Advisor

Twitter : @ppatierno<http://twitter.com/ppatierno>
Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
Blog : DevExperience<http://paolopatierno.wordpress.com/>


________________________________
From: Damian Guy <damian.guy@gmail.com>
Sent: Tuesday, August 1, 2017 2:11 PM
To: dev@kafka.apache.org
Subject: Re: Kafka Streams debugging with "no fluent" API choice

Hi Paolo,

The change would require a KIP as it is a public API change.  I don't see
any harm in making the change, but I also don't think it is that difficult
to use peek to achieve the same thing.

Thanks,
Damian

On Tue, 1 Aug 2017 at 13:52 Paolo Patierno <ppatierno@live.com> wrote:

> Thanks Damian,
>
>
> I knew about that but you have to write the code for printing by yourself=
.
> Of course you can do that even with the print() without using the default
> keyvalue mapper but passing a custom one.
>
> At same time if you want to print you should use a Serdes for key and
> value if they are bytes and it's something which happens for free with
> print() passing Serdes instances.
>
>
> Another point is ...
>
> as both foreach() and peek() methods relies on the KStreamPeek node, it
> could be the same for the print() method which uses a KStreamPrint that i=
s
> a special KStreamPeek with forwardDownStream =3D false and providing the
> usage of Serdes. For this I have opened the following JIRA :
>
>
> https://issues.apache.org/jira/browse/KAFKA-5684
>
>
> What do you think ?
>
>
> Thanks
>
>
> Paolo Patierno
> Senior Software Engineer (IoT) @ Red Hat
> Microsoft MVP on Windows Embedded & IoT
> Microsoft Azure Advisor
>
> Twitter : @ppatierno<http://twitter.com/ppatierno>
> Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
> Blog : DevExperience<http://paolopatierno.wordpress.com/>
>
>
> ________________________________
> From: Damian Guy <damian.guy@gmail.com>
> Sent: Tuesday, August 1, 2017 12:11 PM
> To: dev@kafka.apache.org
> Subject: Re: Kafka Streams debugging with "no fluent" API choice
>
> I don't know specifically why this is removed, however if you want to get
> the same functionality you can use peek, i.e:
>
> stream.map(...).peek(...).filter(..)
>
> You can log the key values out in the peek call.
>
> On Tue, 1 Aug 2017 at 11:48 Paolo Patierno <ppatierno@live.com> wrote:
>
> > Hi guys,
> >
> >
> > I was thinking about Kafka Streams debug features and why the print()
> > method overloads didn't return a KStream, in order to have a fluent DSL
> > construction even during debugging, but just void.
> >
> > Then I came across this PR :
> >
> >
> > https://github.com/apache/kafka/pull/1187
> >
> >
> > May I ask why the form :
> >
> >
> > stream1 =3D source.map(...).filter(...);
> > stream1.print();   // this is for debugging, deleted before moving to
> > productiong
> >
> > stream2 =3D stream1.transform(...);
> > stream2.print();   // this is for debugging, deleted before moving to
> > productiong
> >
> > was considered better then the fluent one :
> >
> >
> > source.map(...).filter(...)
> >           .print()   // this is for debugging, deleted before moving to
> > productiong
> >           .transform(...)
> >           .print();   // this is for debugging, deleted before moving t=
o
> > productiong
> >
> >
> > In this first case the user has to break the topology for printing and
> > after that, when the code works fine, he has to rewrite the code for
> > avoiding these broken processors having a fluent construction.
> >
> > In the second solution, the user has just to remove the print() calls
> > without touching the other parts of the code.
> >
> > I really liked the first solution (it was something I was going to
> propose
> > before coming across the PR :-)).
> >
> >
> > Why this preference on the first one ?
> >
> >
> > Thanks
> >
> >
> >
> > Paolo Patierno
> > Senior Software Engineer (IoT) @ Red Hat
> > Microsoft MVP on Windows Embedded & IoT
> > Microsoft Azure Advisor
> >
> > Twitter : @ppatierno<http://twitter.com/ppatierno>
> > Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
> > Blog : DevExperience<http://paolopatierno.wordpress.com/>
> >
>

--_000_HE1PR0202MB29062E63356137442C710CEEC9B30HE1PR0202MB2906_--