Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
From: Paolo Patierno <ppatierno@live.com>
To: "dev@kafka.apache.org" <dev@kafka.apache.org>
Subject: Re: KStreamPrintTest : no differences in the unit tests
Thread-Topic: KStreamPrintTest : no differences in the unit tests
Thread-Index: AQHTC5tg5XZT+tWK/kiQzW1PJybKDqJxUoQAgAEARoY=
Date: Thu, 3 Aug 2017 08:47:32 +0000
Message-ID: <DB6PR0202MB290141A87832AAC2BD411456C9B10@DB6PR0202MB2901.eurprd02.prod.outlook.com>
References: <DB6PR0202MB2901C41CA383BFCADFDCF878C9B00@DB6PR0202MB2901.eurprd02.prod.outlook.com>,<CAJikTEUaXNeTRRWQPNoRFwvE=4=jtVB=Vpsc4Szm6pt67gSUmg@mail.gmail.com>
In-Reply-To: <CAJikTEUaXNeTRRWQPNoRFwvE=4=jtVB=Vpsc4Szm6pt67gSUmg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [aQDkixcO63sHyxrsBwL/SNGzRYcmYwk8]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;AM5EUR02HT036;7:njyIbjy9FD8oaIxg/+ENZ0XdyKmSJERW1unfp07qfne3b8kpfoV4x1BR/IjnSDUbCqXpq5jTLIJg1DMauRSGf1p43ytlEPOuzJ/w488zLEplV7dvGNgWVH5Pp5Z5CALwWQ3mkuVTKeF1E2Rc/aSuDR6cnio23ixjhuxixgY6QFLPCAwXkW5mXWFNsocDaIVJbJHg17ydb8kBzNwzkUDTYk7pBR3htU/GJ2gKOBv2bBLcTrWPAcuoZ37ldGoK9cveaRlZQrpOEswBwMvrAWM8iVwHQn9lgzkgGl+gjR0XbpeYv1idVmPl8Uwso6M5wr4fhBU82otkmlB6ZTFJMfM3Xi/R6z2dsM/9p3a9Hwe4U91k0PGotfSfNBKR/lM1fu1bbQ+9ATBVkKva/Ehdziqt90TX7LZooHnTh4FPjgIOumMbv2DTj+sjtYI91KkAFn8qa4RnuWaIpEOxf/BzKs6BE1QfhXXXuLDN+Tp4vmtTHfjNP52qOoE/3Dc2E0a3zPcBPX1XvcwB4ZcLeuNX8gJ9fe0sxWf+23YyZsVOa+hRvGcmSv7LXrRJ5VirMZPSiIPNdhdLeuilPRYVdPtF8ghJYt2n8m5dY48UMByumSSFll+QXY3244hh8A7L3KFRoW1T26VdyliAe1IiRBt+eolsAbZeFfsRkvV2lG6iSF7lit8PiUogVrDh9GN8jHaAearyHKAPY1IcW9EOa88Y/jdiYnagSEO7igB/D2k1tDrrqUsOpZXFZWjlhCZnebtgjXnz958Wyy5yyN5bjGR+lNQDrA==
x-incomingheadercount: 45
x-eopattributedmessage: 0
x-forefront-antispam-report: EFV:NLI;SFV:NSPM;SFS:(7070007)(98901004);DIR:OUT;SFP:1901;SCL:1;SRVR:AM5EUR02HT036;H:DB6PR0202MB2901.eurprd02.prod.outlook.com;FPR:;SPF:None;LANG:en;
x-ms-office365-filtering-correlation-id: 95ae13bf-1149-434e-9467-08d4da4c47cf
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322377)(1603101448)(1601125374)(1701031045)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AM5EUR02HT036;
x-ms-traffictypediagnostic: AM5EUR02HT036:
x-exchange-antispam-report-test: UriScan:(148322886591682)(166708455590820)(31418570063057)(47647156867600)(37052965297144)(116415991822766)(81160342030619)(105182351903845);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(444000031);SRVR:AM5EUR02HT036;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM5EUR02HT036;
x-forefront-prvs: 03883BD916
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_DB6PR0202MB290141A87832AAC2BD411456C9B10DB6PR0202MB2901_"
MIME-Version: 1.0
X-OriginatorOrg: live.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2017 08:47:32.2769
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5EUR02HT036
archived-at: Thu, 03 Aug 2017 08:47:52 -0000

--_000_DB6PR0202MB290141A87832AAC2BD411456C9B10DB6PR0202MB2901_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hi Damian,


I submit the patch as part of this PR


 https://github.com/apache/kafka/pull/3611


adding a couple of other tests as well.

Maybe you can take a look at it :-)


Thanks !


Paolo Patierno
Senior Software Engineer (IoT) @ Red Hat
Microsoft MVP on Windows Embedded & IoT
Microsoft Azure Advisor

Twitter : @ppatierno<http://twitter.com/ppatierno>
Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
Blog : DevExperience<http://paolopatierno.wordpress.com/>


________________________________
From: Damian Guy <damian.guy@gmail.com>
Sent: Wednesday, August 2, 2017 5:29 PM
To: dev@kafka.apache.org
Subject: Re: KStreamPrintTest : no differences in the unit tests

Yes - they are basically the same. Feel free to submit a patch to remove
one of them

On Wed, 2 Aug 2017 at 15:28 Paolo Patierno <ppatierno@live.com> wrote:

> Hi devs,
>
> taking a look at KStreamPrintTest I can't find any substantial difference
> between the two tests :
>
>
> testPrintStreamWithProvidedKeyValueMapper
>
> testPrintKeyValueWithName
>
>
> The only tiny difference is the mapper output "%d, %s" instead of "(%d,
> %s)" but then all the code seems to be the same (some other "final" missi=
ng
> ...).
>
> Is there something that my eyes can't see ?
>
>
> Thanks,
>
>
> Paolo Patierno
> Senior Software Engineer (IoT) @ Red Hat
> Microsoft MVP on Windows Embedded & IoT
> Microsoft Azure Advisor
>
> Twitter : @ppatierno<http://twitter.com/ppatierno>
> Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
> Blog : DevExperience<http://paolopatierno.wordpress.com/>
>

--_000_DB6PR0202MB290141A87832AAC2BD411456C9B10DB6PR0202MB2901_--