Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
MIME-Version: 1.0
In-Reply-To: <HE1PR0202MB2906DCCE6B14123B216CBCCAC9B30@HE1PR0202MB2906.eurprd02.prod.outlook.com>
References: <CAMd5Ysy3bY7Fq2xA3sk6BWW6=9TjT4+ya7mufRf6Wgre-S-UPg@mail.gmail.com>
 <CAMd5Yszc2cY5jZGq=ctfQ9pYvm8Btyo1osrdY2zvUS8CSrDPFA@mail.gmail.com>
 <CAD5tkZY2hky26Z=QZvHPvX9zCq0MSc=0EjsnxHLpox9Oaz7sHw@mail.gmail.com>
 <CAMd5Yszx1Uxnj8eegVVj3HOmZty0nmQqdheD3D=f3gN87uxuqA@mail.gmail.com>
 <DB6PR0202MB2901295536F875D9DCFAEB89C9B80@DB6PR0202MB2901.eurprd02.prod.outlook.com>
 <CAD5tkZY-=qv6udrLuxbzi=H=+ssis9KUqBD8+ZTJQzHgiimfmg@mail.gmail.com>
 <CAMd5YszpBZaY3xD58D6qDUsRH33sbK6koW+OmqEajL_P-jJoHw@mail.gmail.com>
 <DB6PR0202MB2901CF77360E2C4CE365671CC9B80@DB6PR0202MB2901.eurprd02.prod.outlook.com>
 <CAMd5Ysyp7LXbXH250GBcXFDN97UAHJFdAoXg0Q5owvghsR-_Yw@mail.gmail.com>
 <CAMd5YsyB_rd03j=FMRydOXKxBAkGJYu0OhN85ufxhWaSzzMT4w@mail.gmail.com>
 <CAMd5YswfwuHVXTJ8+kquMvPJgr-RK7VdhaRB+t+h-H52X1GQ5w@mail.gmail.com>
 <CAD5tkZYYesUtARW0=XHPVqFwUc3F7NHsb6qDPc_fUD=Myyzjig@mail.gmail.com>
 <CAMd5Ysw=LEfVwDriV44KhbZL6+YiBfyH5+0w57mGdOKHX2n8CQ@mail.gmail.com> <HE1PR0202MB2906DCCE6B14123B216CBCCAC9B30@HE1PR0202MB2906.eurprd02.prod.outlook.com>
From: Tom Bentley <t.j.bentley@gmail.com>
Date: Tue, 1 Aug 2017 16:52:10 +0100
Message-ID: <CAMd5YswEYgjkhFVhUChC7DAX3JR61YGqzWoxchBKCJ_+zzJsdw@mail.gmail.com>
Subject: Re: [DISCUSS] KIP-179: Change ReassignPartitionsCommand to use AdminClient
To: dev@kafka.apache.org
Content-Type: multipart/alternative; boundary="001a11464f006dae3c0555b32179"
archived-at: Tue, 01 Aug 2017 15:52:26 -0000

--001a11464f006dae3c0555b32179
Content-Type: text/plain; charset="UTF-8"

> Regarding adding the possibility to alter the topic config through the
> AlterTopic API, the current TopicCommand implementation provides a warning
> on doing this suggesting to use the ConfigCommand tool. So it would be a
> step back allowing to do the configs change with the alter topic as well.
>

To be clear, I'm not proposing that this be supported via the
kafka-reassign-partitions.sh tool, nor via kafka-topics.sh. It's purely a
question of whether the API for the AlterTopicsRequest/Response and the
AdminClient API would support it. As I said, I really don't like the
duplication of functionality and would prefer to leave it out, even though
it makes for a less "symmetric" API wrt CreateTopicsRequest/Response, but
maybe the community feels otherwise.

--001a11464f006dae3c0555b32179--