kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pranav Maniar <pranav9...@gmail.com>
Subject [DISCUSS] KAFKA-1944 Rename LogCleaner to LogCompactor
Date Wed, 02 Aug 2017 06:52:51 GMT
Hi All,

I am planning to take up [KAFKA-1944
<https://issues.apache.org/jira/browse/KAFKA-1944>] : Rename LogCleaner to
Renaming will cover LogCleander, LogCleanerManager, related Testcases and
all method/variable/documentations inside it.

It also requires configuration name change *"log.cleaner.enable"* to
*"log.compactor.enable"*. As suggestion given on KAFKA-1944
<https://issues.apache.org/jira/browse/KAFKA-1944> deprecating new config
first and eventually deleting it seems to be the preferred approach.

Along with these changes, below classes also seems related to me.
But since I am new to the code-base, I might be missing something.

So I am starting this discussion for getting views/suggestions on any of
the below will also require renaming along with above change?

Classes :

   - CleanerConfig
   - LogCleaningAbortedException

Config :

   - log.cleaner.backoff.ms
   - log.cleaner.dedupe.buffer.size
   - log.cleaner.delete.retention.ms
   - log.cleaner.enable
   - log.cleaner.io.buffer.load.factor
   - log.cleaner.io.buffer.size
   - log.cleaner.io.max.bytes.per.second
   - log.cleaner.min.cleanable.ratio
   - log.cleaner.min.compaction.lag.ms
   - log.cleaner.threads
   - log.cleanup.policy


  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message