kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Gustafson <ja...@confluent.io>
Subject Re: [DISCUSS] KAFKA-1944 Rename LogCleaner to LogCompactor
Date Wed, 02 Aug 2017 17:42:35 GMT
Hey Pranav,

Thanks for raising this. I already commented on the JIRA, but I'll
reiterate my thoughts here. The "log cleaner" naming may not be ideal, but
it is not incorrect and some of the terminology used elsewhere makes more
sense given this name (e.g. cleanable ratio, dirty offset). I personally
see little benefit in the name change, especially if we have to propagate
the change to configuration names (and it makes little sense if we do not
do so). My guess is that most users have already gotten used to the "log
cleaner" naming anyway, so adding new configs would just cause confusion.

However, I do think we should consider deprecating log.cleaner.enable since
it is now enabled by default and some of the core components depend on it.
I would support a KIP which did just that.

-Jason

On Tue, Aug 1, 2017 at 11:52 PM, Pranav Maniar <pranav9428@gmail.com> wrote:

> Hi All,
>
> I am planning to take up [KAFKA-1944
> <https://issues.apache.org/jira/browse/KAFKA-1944>] : Rename LogCleaner to
> LogCompactor.
> Renaming will cover LogCleander, LogCleanerManager, related Testcases and
> all method/variable/documentations inside it.
>
> It also requires configuration name change *"log.cleaner.enable"* to
> *"log.compactor.enable"*. As suggestion given on KAFKA-1944
> <https://issues.apache.org/jira/browse/KAFKA-1944> deprecating new config
> first and eventually deleting it seems to be the preferred approach.
>
> Along with these changes, below classes also seems related to me.
> But since I am new to the code-base, I might be missing something.
>
> So I am starting this discussion for getting views/suggestions on any of
> the below will also require renaming along with above change?
>
> Classes :
>
>    - CleanerConfig
>    - LogCleaningAbortedException
>
>
> Config :
>
>    - log.cleaner.backoff.ms
>    - log.cleaner.dedupe.buffer.size
>    - log.cleaner.delete.retention.ms
>    - log.cleaner.enable
>    - log.cleaner.io.buffer.load.factor
>    - log.cleaner.io.buffer.size
>    - log.cleaner.io.max.bytes.per.second
>    - log.cleaner.min.cleanable.ratio
>    - log.cleaner.min.compaction.lag.ms
>    - log.cleaner.threads
>    - log.cleanup.policy
>
>
> Thanks,
> Pranav
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message