kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ismael Juma <ism...@juma.me.uk>
Subject Re: [DISCUSS] KIP-179: Change ReassignPartitionsCommand to use AdminClient
Date Tue, 01 Aug 2017 16:52:36 GMT
Hi both,

Thanks for the replies. A few points:

1. It's worth emphasising that reassigning partitions is a different
process than what happens when a topic is created, so not sure trying to
make it symmetric is beneficial. In addition to what was already discussed,
one should also enable replication throttling before moving the data.

2. HTTP codes are not a great comparison as they are per response while
Kafka responses often include multiple error codes (due to batching).

3. In my opinion, the warning when someone updates configs via
`kafka-topic.sh` was a mistake. Doing the same thing via the configs tool
is quite clunky in comparison.


On Tue, Aug 1, 2017 at 4:52 PM, Tom Bentley <t.j.bentley@gmail.com> wrote:

> > Regarding adding the possibility to alter the topic config through the
> > AlterTopic API, the current TopicCommand implementation provides a
> warning
> > on doing this suggesting to use the ConfigCommand tool. So it would be a
> > step back allowing to do the configs change with the alter topic as well.
> >
> To be clear, I'm not proposing that this be supported via the
> kafka-reassign-partitions.sh tool, nor via kafka-topics.sh. It's purely a
> question of whether the API for the AlterTopicsRequest/Response and the
> AdminClient API would support it. As I said, I really don't like the
> duplication of functionality and would prefer to leave it out, even though
> it makes for a less "symmetric" API wrt CreateTopicsRequest/Response, but
> maybe the community feels otherwise.

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message