kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From umesh9794 <...@git.apache.org>
Subject [GitHub] kafka pull request #3489: KAFKA-5556 : KafkaConsumer.commitSync throws Illeg...
Date Wed, 05 Jul 2017 10:52:43 GMT
GitHub user umesh9794 opened a pull request:

    https://github.com/apache/kafka/pull/3489

    KAFKA-5556 : KafkaConsumer.commitSync throws IllegalStateException: A…

    This PR makes `commitOffsetsSync` method check whether future is completed after client's
poll or not. 
    
    Tests: All existing tests especially "`testCommitOffsetSyncCallbackWithNonRetriableException`"
is passed. Not sure if we need to add any dedicated tests for this minor change. 
    
    Awaiting your review comments. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/umesh9794/kafka KAFKA-5556

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3489.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3489
    
----
commit 1d44ca726026aea7bb030d5eecb5d4a197b5b0b9
Author: umesh chaudhary <umesh9794@gmail.com>
Date:   2017-07-05T10:45:59Z

    KAFKA-5556 : KafkaConsumer.commitSync throws IllegalStateException: Attempt to retrieve
exception from future which hasn't failed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message