kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "james chien (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-4772) Exploit #peek to implement #print() and other methods
Date Tue, 02 May 2017 01:54:05 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-4772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991968#comment-15991968
] 

james chien commented on KAFKA-4772:
------------------------------------

Great !! 
what should I do now? (keep going this comment https://github.com/apache/kafka/pull/2704#issuecomment-294661203
or make a new PR)
(I am very excited now :) )

> Exploit #peek to implement #print() and other methods
> -----------------------------------------------------
>
>                 Key: KAFKA-4772
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4772
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: james chien
>            Priority: Minor
>              Labels: beginner, newbie
>
> From: https://github.com/apache/kafka/pull/2493#pullrequestreview-22157555
> Things that I can think of:
> - print / writeAsTest can be a special impl of peek; KStreamPrint etc can be removed.
> - consider collapse KStreamPeek with KStreamForeach with a flag parameter indicating
if the acted key-value pair should still be forwarded.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message