Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4A45A200BF2 for ; Mon, 2 Jan 2017 23:55:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4732F160B22; Mon, 2 Jan 2017 22:55:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8F012160B16 for ; Mon, 2 Jan 2017 23:54:59 +0100 (CET) Received: (qmail 14271 invoked by uid 500); 2 Jan 2017 22:54:58 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 14260 invoked by uid 99); 2 Jan 2017 22:54:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jan 2017 22:54:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6E0312C03DE for ; Mon, 2 Jan 2017 22:54:58 +0000 (UTC) Date: Mon, 2 Jan 2017 22:54:58 +0000 (UTC) From: "Ismael Juma (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-4459) rat license check not running in Jenkins MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 02 Jan 2017 22:55:00 -0000 [ https://issues.apache.org/jira/browse/KAFKA-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793651#comment-15793651 ] Ismael Juma commented on KAFKA-4459: ------------------------------------ [~ewencp], the command for the job I linked to is: {code} ./gradlew --no-daemon -Dorg.gradle.project.maxParallelForks=1 -Dorg.gradle.project.testLoggingEvents=started,passed,skipped,failed clean testAll {code} It hasn't changed recently. I only changed the PR jobs. > rat license check not running in Jenkins > ---------------------------------------- > > Key: KAFKA-4459 > URL: https://issues.apache.org/jira/browse/KAFKA-4459 > Project: Kafka > Issue Type: Bug > Reporter: Ismael Juma > Fix For: 0.10.2.0 > > > The following commit introduced files without a license, which causes rat to fail when run locally: > https://github.com/apache/kafka/commit/e035fc039598127e88f31739458f705290b1fdba > However, the build passed in Jenkins: > https://builds.apache.org/job/kafka-trunk-jdk7/1710/ > Not sure why, but a potential culprit is the check for `.git` in the build: > {code} > if (new File('.git').exists()) { > apply from: file('gradle/rat.gradle') > rat { > // Exclude everything under the directory that git should be ignoring via .gitignore or that isn't checked in. These > // restrict us only to files that are checked in or are staged. > def repo = Grgit.open(project.file('.')) > excludes = new ArrayList(repo.clean(ignore: false, directories: true, dryRun: true)) > // And some of the files that we have checked in should also be excluded from this check > excludes.addAll([ > '**/.git/**', > '**/build/**', > 'CONTRIBUTING.md', > 'gradlew', > 'gradlew.bat', > '**/README.md' > ]) > } > } > {code} > If the current directory in Jenkins is not the repo directory, it could fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)