kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ismael Juma <ism...@juma.me.uk>
Subject Re: [VOTE] KIP-102 - Add close with timeout for consumers
Date Fri, 06 Jan 2017 10:26:08 GMT
Thanks for the KIP, +1 (binding).

As I said in the discussion thread, I'm not too sure about the hardcoded 30
seconds timeout for the no-args `close` method. Still, it's an improvement
over what is in trunk at the moment and I don't have a good alternative
given that request.timeout is pretty long by default (5 minutes).

Ismael

On Thu, Jan 5, 2017 at 10:07 PM, Rajini Sivaram <rajinisivaram@gmail.com>
wrote:

> Hi all,
>
>
> I would like to start the voting process for *KIP-102 - Add close with
> timeout for consumers*:
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 102+-+Add+close+with+timeout+for+consumers
>
>
>
> This KIP adds a new close method with a timeout for consumers similar to
> the close method in the producer. As described in the discussion thread
> <http://mail-archives.apache.org/mod_mbox/kafka-dev/201612.mbox/%3cCAG_+
> N9uS5OHtHwMyai9PZ4s2J62fMiLS2UfJ8oiE9JpmyAF_Bg@mail.gmail.com%3e>,
> the changes are only in the close code path and hence the impact is not too
> big. The existing close() method without a timeout will use a default
> timeout of 30 seconds.
>
>
> Thank you....
>
>
> Regards,
>
>
> Rajini
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message