Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9E874200B78 for ; Fri, 2 Sep 2016 10:15:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9D381160AAB; Fri, 2 Sep 2016 08:15:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E103F160ACB for ; Fri, 2 Sep 2016 10:15:21 +0200 (CEST) Received: (qmail 24010 invoked by uid 500); 2 Sep 2016 08:15:21 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 23969 invoked by uid 99); 2 Sep 2016 08:15:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2016 08:15:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BF8FD2C1B83 for ; Fri, 2 Sep 2016 08:15:20 +0000 (UTC) Date: Fri, 2 Sep 2016 08:15:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-3703) PlaintextTransportLayer.close() doesn't complete outgoing writes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 02 Sep 2016 08:15:22 -0000 [ https://issues.apache.org/jira/browse/KAFKA-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457896#comment-15457896 ] ASF GitHub Bot commented on KAFKA-3703: --------------------------------------- GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/1817 KAFKA-3703: Flush outgoing writes before closing client selector Close client connections only after outgoing writes complete or timeout. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-3703 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1817.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1817 ---- commit 50f009bebe0beaf55cb5e00f9db8fcb626f1399a Author: Rajini Sivaram Date: 2016-09-02T07:55:49Z KAFKA-3703: Flush outgoing writes before closing client selector ---- > PlaintextTransportLayer.close() doesn't complete outgoing writes > ---------------------------------------------------------------- > > Key: KAFKA-3703 > URL: https://issues.apache.org/jira/browse/KAFKA-3703 > Project: Kafka > Issue Type: Bug > Reporter: Rajini Sivaram > Assignee: Rajini Sivaram > > Outgoing writes may be discarded when a connection is closed. For instance, when running a producer with acks=0, a producer that writes data and closes the producer would expect to see all writes to complete if there are no errors. But close() simply closes the channel and socket which could result in outgoing data being discarded. -- This message was sent by Atlassian JIRA (v6.3.4#6332)