Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Tue, 7 Jun 2016 14:20:21 +0000 (UTC)
From: "Jeff Klukas (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.12969627.1463170495000.14074.1465309221058@Atlassian.JIRA>
In-Reply-To: <JIRA.12969627.1463170495000@Atlassian.JIRA>
References: <JIRA.12969627.1463170495000@Atlassian.JIRA> <JIRA.12969627.1463170495281@arcas>
Subject: [jira] [Commented] (KAFKA-3711) Allow configuration of
 MetricsReporter subclasses
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 07 Jun 2016 14:20:23 -0000


    [ https://issues.apache.org/jira/browse/KAFKA-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318546#comment-15318546 ] 

Jeff Klukas commented on KAFKA-3711:
------------------------------------

I would love to see this fixed as well. I'd also love to see some more documentation about Kafka's config framework and how various interfaces like {{MetricsReporter}} are intended to be used. Specifically, I'd like to see the developer docs describe that it's intended that user-provided classes can define configuration options and provide some advice about how to name those options.

I'd be interested in contributing docs and cleaning up the config code if it's clear what needs to be done. Am I correct in understanding that the code change needed here is to ensure that {{originals()}} is called rather than {{this.originals}} everywhere that we're passing configs on in {{AbstractConfig}}?

> Allow configuration of MetricsReporter subclasses
> -------------------------------------------------
>
>                 Key: KAFKA-3711
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3711
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients, streams
>            Reporter: Jeff Klukas
>            Assignee: Guozhang Wang
>            Priority: Minor
>             Fix For: 0.10.1.0
>
>
> The current interface for attaching metrics reporters to clients allows only defining a list of class names, but provides no means for configuring those reporters.
> There is at least one existing project (https://github.com/apakulov/kafka-graphite) that solves this problem by passing additional properties into the client, which then get passed on to the reporter. This seems to work quite well, but it generates warnings like {{The configuration kafka.graphite.metrics.prefix = foo was supplied but isn't a known config.}}
> Should passing arbitrary additional parameters like this be officially supported as the way to configure metrics reporters? Should these warnings about unrecognized parameters be removed?
> Perhaps there should be some mechanism for registering additional configuration parameters for clients to expect?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)