Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Sat, 4 Jun 2016 15:22:59 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.12958904.1460654946000.33699.1465053779259@Atlassian.JIRA>
In-Reply-To: <JIRA.12958904.1460654946000@Atlassian.JIRA>
References: <JIRA.12958904.1460654946000@Atlassian.JIRA> <JIRA.12958904.1460654946259@arcas>
Subject: [jira] [Commented] (KAFKA-3561) Auto create through topic for
 KStream aggregation and join
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 04 Jun 2016 15:23:01 -0000


    [ https://issues.apache.org/jira/browse/KAFKA-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315545#comment-15315545 ] 

ASF GitHub Bot commented on KAFKA-3561:
---------------------------------------

Github user dguy closed the pull request at:

    https://github.com/apache/kafka/pull/1453


> Auto create through topic for KStream aggregation and join
> ----------------------------------------------------------
>
>                 Key: KAFKA-3561
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3561
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Damian Guy
>              Labels: api
>             Fix For: 0.10.1.0
>
>
> For KStream.join / aggregateByKey operations that requires the streams to be partitioned on the record key, today users should repartition themselves through the "through" call:
> {code}
> stream1 = builder.stream("topic1");
> stream2 = builder.stream("topic2");
> stream3 = stream1.map(/* set the right key for join*/).through("topic3");
> stream4 = stream2.map(/* set the right key for join*/).through("topic4");
> stream3.join(stream4, ..)
> {code}
> This pattern can actually be done by the Streams DSL itself instead of requiring users to specify themselves, i.e. users can just set the right key like (see KAFKA-3430) and then call join, which will be translated by adding the "internal topic for repartition".
> Another thing is that today if user do not call "through" after setting a new key, the aggregation result would not be correct as the aggregation is based on key B while the source partitions is partitioned by key A and hence each task will only get a partial aggregation for all keys. But this is not validated in the DSL today. We should do both the auto-translation and validation.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)