kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-3755) tightening the offset check in ReplicaFetcherThread
Date Tue, 14 Jun 2016 22:30:30 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330773#comment-15330773
] 

ASF GitHub Bot commented on KAFKA-3755:
---------------------------------------

GitHub user imandhan opened a pull request:

    https://github.com/apache/kafka/pull/1506

    KAFKA-3755 Tightening the offset check in ReplicaFetcherThread

    Including an additional check to make sure that the first offset in the message set to
be appended to the log is >= than the log end offset.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/imandhan/kafka KAFKA-3755

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1506
    
----
commit ed674a9b3e4b4ab5531326396ef59950a2930467
Author: Ishita Mandhan <imandha@us.ibm.com>
Date:   2016-06-14T22:28:24Z

    KAFKA-3755 Tightening the offset check in ReplicaFetcherThread
    
    Including additional check to make sure that the first offset in the message set to be
appended to the log is >= than the log end offset.

----


> tightening the offset check in ReplicaFetcherThread
> ---------------------------------------------------
>
>                 Key: KAFKA-3755
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3755
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jun Rao
>            Assignee: Ishita Mandhan
>
> Currently, in ReplicaFetcherThread.processPartitionData(), we have the following code
to make sure that the fetchOffset matches the log end offset.
>       if (fetchOffset != replica.logEndOffset.messageOffset)
>         throw new RuntimeException("Offset mismatch for partition %s: fetched offset
= %d, log end offset = %d.".format(topicAndPartition, fetchOffset, replica.logEndOffset.messageOffset))
> It would be useful to further assert that the first offset in the messageSet to be appended
to the log is >= than the log end offset.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message