kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (KAFKA-3755) tightening the offset check in ReplicaFetcherThread
Date Thu, 16 Jun 2016 22:50:05 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Jun Rao resolved KAFKA-3755.
    Resolution: Not A Problem

As notes in the PR, looks like Log.append() already has that check. See https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/log/Log.scala#L370

Closing the jira.

> tightening the offset check in ReplicaFetcherThread
> ---------------------------------------------------
>                 Key: KAFKA-3755
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3755
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jun Rao
>            Assignee: Ishita Mandhan
> Currently, in ReplicaFetcherThread.processPartitionData(), we have the following code
to make sure that the fetchOffset matches the log end offset.
>       if (fetchOffset != replica.logEndOffset.messageOffset)
>         throw new RuntimeException("Offset mismatch for partition %s: fetched offset
= %d, log end offset = %d.".format(topicAndPartition, fetchOffset, replica.logEndOffset.messageOffset))
> It would be useful to further assert that the first offset in the messageSet to be appended
to the log is >= than the log end offset.

This message was sent by Atlassian JIRA

View raw message