Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 440961818F for ; Thu, 14 Jan 2016 08:51:42 +0000 (UTC) Received: (qmail 35518 invoked by uid 500); 14 Jan 2016 08:51:41 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 35391 invoked by uid 500); 14 Jan 2016 08:51:41 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 35361 invoked by uid 99); 14 Jan 2016 08:51:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jan 2016 08:51:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5190EE0AF1; Thu, 14 Jan 2016 08:51:41 +0000 (UTC) From: ijuma To: dev@kafka.apache.org Reply-To: dev@kafka.apache.org Message-ID: Subject: [GitHub] kafka pull request: KAFKA-3105: Use `Utils.atomicMoveWithFallback`... Content-Type: text/plain Date: Thu, 14 Jan 2016 08:51:41 +0000 (UTC) GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/771 KAFKA-3105: Use `Utils.atomicMoveWithFallback` instead of `File.rename` It behaves better on Windows and provides more useful error messages. Also: * Minor inconsistency fix in `kafka.server.OffsetCheckpoint`. * Remove delete from `streams.state.OffsetCheckpoint` constructor (similar to the change in `kafka.server.OffsetCheckpoint` in https://github.com/apache/kafka/commit/836cb1963330a9e342379899e0fe52b72347736e#diff-2503b32f29cbbd61ed8316f127829455L29). You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-3105-use-atomic-move-with-fallback-instead-of-rename Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/771.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #771 ---- commit e4c94793bd0bd82baf9c3be61046b719182878bf Author: Ismael Juma Date: 2016-01-14T08:45:49Z Use `Utils.atomicMoveWithFallback` instead of `File.rename` It behaves better on Windows and provides more useful error messages. commit e9894b9691f8d865b8c1a3afe989ae17ccbf15fe Author: Ismael Juma Date: 2016-01-14T08:47:08Z Minor inconsistency fix in `OffsetCheckpoint.malformedLineException` commit 29372fa2d3fbe4cfb5b4b88184539e5c9ac405b2 Author: Ismael Juma Date: 2016-01-14T08:48:44Z Remove delete from `streams.state.OffsetCheckpoint` constructor This is similar to the change in kafka.server.OffsetCheckpoint. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---