Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 52EF818390 for ; Wed, 13 Jan 2016 20:05:40 +0000 (UTC) Received: (qmail 97233 invoked by uid 500); 13 Jan 2016 20:05:40 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 97121 invoked by uid 500); 13 Jan 2016 20:05:39 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 97110 invoked by uid 99); 13 Jan 2016 20:05:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2016 20:05:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BDF922C14F0 for ; Wed, 13 Jan 2016 20:05:39 +0000 (UTC) Date: Wed, 13 Jan 2016 20:05:39 +0000 (UTC) From: "Ismael Juma (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (KAFKA-3100) Broker.createBroker should work if json is version > 2, but still compatible MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Ismael Juma created KAFKA-3100: ---------------------------------- Summary: Broker.createBroker should work if json is version > 2, but still compatible Key: KAFKA-3100 URL: https://issues.apache.org/jira/browse/KAFKA-3100 Project: Kafka Issue Type: Improvement Components: core Affects Versions: 0.9.0.0 Reporter: Ismael Juma Assignee: Ismael Juma Fix For: 0.9.0.1 Description from Jun: In 0.9.0.0, the old consumer reads broker info directly from ZK and the code throws an exception if the version in json is not 1 or 2. This old consumer will break when we upgrade the broker json to version 3 in ZK in 0.9.1, which will be an issue. We overlooked this issue in 0.9.0.0. The easiest fix is probably not to check the version in ZkUtils.getBrokerInfo(). This way, as long as we are only adding new fields in broker json, we can preserve the compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)