Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7419E1814F for ; Mon, 11 Jan 2016 14:44:40 +0000 (UTC) Received: (qmail 78946 invoked by uid 500); 11 Jan 2016 14:44:40 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 78760 invoked by uid 500); 11 Jan 2016 14:44:40 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 78737 invoked by uid 99); 11 Jan 2016 14:44:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 14:44:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C4B4C2C14F7 for ; Mon, 11 Jan 2016 14:44:39 +0000 (UTC) Date: Mon, 11 Jan 2016 14:44:39 +0000 (UTC) From: "jin xing (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-3054) Connect Herder fail forever if sent a wrong connector config or task config MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091994#comment-15091994 ] jin xing commented on KAFKA-3054: --------------------------------- [~ewencp] thanks for comment : ) currently the DistributedHerder only catch the ConfigException, thus any other exceptions thrown during connector startup or task startup will kill the DistributedHerder and Worker; If the cluster has only one DistributedHerder, restart will fail forever; It make sense to let the herder swallow all exceptions thrown by connector or task during handling the life cycle of connector and task, thus Herder and Worker can keep running; How do you think? > Connect Herder fail forever if sent a wrong connector config or task config > --------------------------------------------------------------------------- > > Key: KAFKA-3054 > URL: https://issues.apache.org/jira/browse/KAFKA-3054 > Project: Kafka > Issue Type: Bug > Components: copycat > Affects Versions: 0.9.0.0 > Reporter: jin xing > Assignee: jin xing > > Connector Herder throws ConnectException and shutdown if sent a wrong config, restarting herder will keep failing with the wrong config; It make sense that herder should stay available when start connector or task failed; After receiving a delete connector request, the herder can delete the wrong config from "config storage" -- This message was sent by Atlassian JIRA (v6.3.4#6332)