kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-3100) Broker.createBroker should work if json is version > 2, but still compatible
Date Thu, 14 Jan 2016 16:09:39 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098316#comment-15098316
] 

ASF GitHub Bot commented on KAFKA-3100:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/773

    KAFKA-3100; Broker.createBroker should work if json is version > 2 and still compatible

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-3100-create-broker-version-check

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/773.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #773
    
----
commit cab20ca25a317a04818acf3ec81ea8e082ce9b7a
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2016-01-14T16:07:26Z

    Broker.createBroker should work if json is version > 2 and still compatible

----


> Broker.createBroker should work if json is version > 2, but still compatible
> ----------------------------------------------------------------------------
>
>                 Key: KAFKA-3100
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3100
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.9.0.0
>            Reporter: Ismael Juma
>            Assignee: Ismael Juma
>             Fix For: 0.9.0.1
>
>
> Description from Jun:
> In 0.9.0.0, the old consumer reads broker info directly from ZK and the code throws an
exception if the version in json is not 1 or 2. This old consumer will break when we upgrade
the broker json to version 3 in ZK in 0.9.1, which will be an issue. We overlooked this issue
in 0.9.0.0. The easiest fix is probably not to check the version in ZkUtils.getBrokerInfo().
> This way, as long as we are only adding new fields in broker json, we can preserve the
compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message