kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-3063) LogRecoveryTest exits with -1 occasionally
Date Tue, 12 Jan 2016 22:38:39 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095123#comment-15095123
] 

ASF GitHub Bot commented on KAFKA-3063:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/759

    KAFKA-3063; LogRecoveryTest causes JVM to exit occasionally

    Remove deletion of tmp file in `OffsetCheckpoint`'s constructor. This delete causes unintuitive
behaviour like `LogRecoveryTest` causing a `System.exit` because the test creates an instance
of `OffsetCheckpoint` in order to call `read()` on it (while unexpectedly deleting a file
being written by another instance of `OffsetCheckpoint`).
    
    Also:
    * Improve error-handling in `OffsetCheckpoint`
    * Also include minor performance improvements in `read()`
    * Minor clean-ups to `ReplicaManager` and `LogRecoveryTest`
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-3063-log-recovery-test-exits-jvm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/759.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #759
    
----
commit 2312d91d6c01f6c5e4e1c5fc6801cc419d771194
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2016-01-12T22:11:45Z

    Remove deletion of tmp file in `OffsetCheckpoint` constructor
    
    This causes unintuitive behaviour like `LogRecoveryTest` causing
    a `System.exit` because the test creates an instance of `OffsetCheckpoint`
    which in order to call `read()` on it (while unexpectedly deleting a file
    being written by another instance of `OffsetCheckpoint`.

commit 75e10125da005ef8f4c840da0695785f45379e2f
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2016-01-12T22:13:28Z

    Improve error-handling in `OffsetCheckpoint`
    
    Also include minor performance improvements in `read()`:
    * Use mutable map
    * Cache compiled `Pattern` instance

commit d11a7733af5ed64b2943dcdd386e607111b7dd7b
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2016-01-12T22:14:00Z

    Minor clean-ups to `ReplicaManager` and `LogRecoveryTest`

----


> LogRecoveryTest exits with -1 occasionally
> ------------------------------------------
>
>                 Key: KAFKA-3063
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3063
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Guozhang Wang
>            Assignee: Ismael Juma
>             Fix For: 0.9.1.0
>
>
> We see transient failures like the following
> {code}
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':core:test'.
> > Process 'Gradle Test Executor 2' finished with non-zero exit value 1
> {code}
> which are likely to be from an unexpected System.exit(1). But with the current logging
settings it is hard to locate which test cases triggered this failures. More investigations
needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message